Skip to content

Various fixes and optimizations#64

Merged
RecursivePineapple merged 15 commits into
masterfrom
misc-fixes
Jul 16, 2026
Merged

Various fixes and optimizations#64
RecursivePineapple merged 15 commits into
masterfrom
misc-fixes

Conversation

@RecursivePineapple

@RecursivePineapple RecursivePineapple commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Remove double >>4 in scheduleRelightChecksForColumn
  • Prevent BlockRenderer/multi preview crash (likely needs more testing)
  • Don't tick unloaded chunks (improves worldgen speeds)
  • Reduce heightUpdated calls by 16 (only call per block column, not every block)
  • Fix tile description packets
  • Optimize surface tracking syncing (was doing 4096x the work needed)
  • Optimize lighting and fix a few bugs (while also making a few more 😇)
  • Update deps
  • update bs

fixes: #60
fixes: #50
fixes: #52

@RecursivePineapple RecursivePineapple added Bug Fix Fixes a bug. Please link it in the PR if an issue exists for it. Performance Changes with the goal of improving performance. labels Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

#65

@github-actions github-actions Bot mentioned this pull request Jul 6, 2026
Merged
@github-actions
spotlessApply (#65)
788ccb1 
Co-authored-by: GitHub GTNH Actions <>
DarkShadow44
DarkShadow44 reviewed Jul 6, 2026
View reviewed changes

@DarkShadow44 DarkShadow44 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really follow the lighting changes, the rest looks mostly good.

Comment thread src/main/java/com/cardinalstar/cubicchunks/mixin/early/common/MixinWorld_HeightLimit.java Outdated
Comment thread src/main/java/com/cardinalstar/cubicchunks/server/WorldSyncStateMachine.java
Comment thread src/main/java/com/cardinalstar/cubicchunks/mixin/early/common/MixinBlock_Lighting.java
Comment thread src/main/java/com/cardinalstar/cubicchunks/lighting/FirstLightProcessor.java Outdated
@RecursivePineapple
RecursivePineapple merged commit 2fc8ef2 into master Jul 16, 2026
1 check passed
@RecursivePineapple
RecursivePineapple deleted the misc-fixes branch July 16, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkShadow44 DarkShadow44 DarkShadow44 left review comments
@Worive Worive Worive approved these changes
@Cardinalstars Cardinalstars Awaiting requested review from Cardinalstars

Assignees

No one assigned

Labels

Bug Fix Fixes a bug. Please link it in the PR if an issue exists for it. Performance Changes with the goal of improving performance.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tinkers' Smeltery doesn't sync properly Railcraft rails spawned in villages don't render properly Malicious Doors don't update after opening them

3 participants

@RecursivePineapple @DarkShadow44 @Worive