Stops zinc gravel from showing as though it's a valid aluminium sub-soil.#214
Open
C0bra5 wants to merge 7 commits into
Open
Stops zinc gravel from showing as though it's a valid aluminium sub-soil.#214C0bra5 wants to merge 7 commits into
C0bra5 wants to merge 7 commits into
Conversation
C0bra5
added
Bug Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a long-standing issue where NEI sometimes shows zinc gravel as a valid sub-soil for aluminium crops. This is because aluminium gravel somehow gets hit by postea while in NEI (meaning it gets nbt serialized and deserialized).
This PR accomplishes this goal by pushing up some cleanup and optimization work I was planning for 2.10, which allows me to effectively add an NEI-only blacklist when the NH core mod is installed. If a block of alu grave still remains in the world because it didn't get migrated (somehow), or because we disabled the transformer at some point and re-added alu grave to world generation (in case we forget to also yeet the special case from cropsnh when that happens).
Checklist