Remove hungarian notation, Rename underblock systems, and fix nei overflow#212
Merged
Conversation
This is the term communicated to players in every other location so better align with that.
C0bra5
marked this pull request as ready for review
July 11, 2026 14:48
koolkrafter5
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I used regex to find all the variable declarations that used Hungarian notation in CropsNH, and then used IDEA's refactor tool to rename those variables across the project all at once.
Regex used for first pass (case sensitive):
Regex used for second pass (case sensitive, mostly false positives):
A better expression would require full PCRE2 support, so use something like ripgrep with
-P -e "expression". This one will catch variable declarations that use nested generics such asT<U, V<? extends W.X<Y>> mAsd = 2Tests for the regexes
I also used regex to find all mentions of under block, renamed everything manually or using the IDEA's refactor tool.
The new light level message in nei

Checklist