feat: load player progress lazily on connect#225
Open
Caedis wants to merge 6 commits into
Open
Conversation
Per-player progress files were all read at world load. Read each player's file on first connect instead, guarded so reconnects do not clobber newer in-memory progress. Legacy combined file still loads eagerly for migration.
Caedis
added
the
Refactor
Caedis
enabled auto-merge (squash)
May 25, 2026 18:42
tiffit
self-requested a review
May 30, 2026 23:25
tiffit
reviewed
May 30, 2026
Member
There was a problem hiding this comment.
Seems to break something like /bq_admin reset all. Players who haven't logged into the server yet don't have their data reset. This is a minor issue but there might be other things that depend on a player not being online that could break because of this. Probably worth doing some testing for that
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-player progress files were all read at world load. Read each player's file on first connect instead, guarded so reconnects do not clobber newer in-memory progress. Legacy combined file still loads eagerly for migration.