Fix quests in parties not working in LAN worlds#207
Conversation
Ars102987
changed the title
|
Only thing i didnt fix is that in the party UI it shows default skin and uuid instead of nickname, but it is only cosmetic. |
cubefury
left a comment
cubefury
left a comment
There was a problem hiding this comment.
Thank you for your PR, The UUID changes are good! As discussed on discord, the isComplete check might be a bit of a patch that could break other stuff. Let's try revert this to the original check and see if it still works as intended. We can address the cosmetic issues later on!
| return completeUsers.contains(uuid); | ||
| if (completeUsers.contains(uuid)) return true; | ||
|
|
||
| DBEntry<IParty> party = PartyManager.INSTANCE.getParty(uuid); |
There was a problem hiding this comment.
i will try it right now and tell you the outcome
There was a problem hiding this comment.
(Original TaskBase.java) compiled successfully, exact steps: 1. Launch two prism launcher GTNH instances; 2. Create new world and open it to LAN 3. Join with the second account 4. Create party with second account and invite the first (host) account 5. Accept the invite 6. Go back to second account and get 64x dirt for the first quest 7. It completes but the reward cant be claimed on the nonhost acconut
(Modified TaskBase.java) compiled successfully (Same steps till the No 7) 7. It completes and you can claim reward on both accounts
But i found an bug that for some reason allowed me to claim the reward 3x times
Steps: 1. Launch two prism launcher GTNH instances; 2. Create new world and open it to LAN 3. Join with the second account 4. Create party with second account and invite the first (host) account 5. Accept the invite 6. Go back to second account and get 64x dirt for the first quest 7. Claim on second account 8. Claim on the host account (first) 9. Go back on the second account and reopen the quest menu (and wait around 5s), and you can again reclaim the already claimed reward 10. Step 8 (infinite dupe bug)
Dont really know what is the reason
|
@Ars102987 any news . pr has conflicts |
3 participants
Was only tested with 1 online and 1 offline (cracked) account in LAN, probably requires more testing in more cases (as for example LAN using RadminVPN)
Was not tested with dedicated server, but in LAN worlds claiming rewards and detecting quest completion is working (only the UI is a bit buggy)