Skip to content

Delegate rendering to IItemRenderers#53

Merged
Dream-Master merged 3 commits into
masterfrom
remove-filth
Jun 19, 2026
Merged

Delegate rendering to IItemRenderers#53
Dream-Master merged 3 commits into
masterfrom
remove-filth

Conversation

@FourIsTheNumber

@FourIsTheNumber FourIsTheNumber commented Jun 18, 2026

Copy link
Copy Markdown

Fixes a crash with mechanical armor and gt tools not rendering in GUI. Removes all of the custom reflection-based handling for item rendering and just calls the item's assigned IItemRenderers.

@FourIsTheNumber FourIsTheNumber added Bug Fix Fixes a bug. Please link it in the PR if an issue exists for it. Refactor For PRs rewriting a part of the code to have a nicer code overall. labels Jun 18, 2026
MalTeeez
MalTeeez approved these changes Jun 18, 2026
View reviewed changes

@MalTeeez MalTeeez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Carver reigns again

Algent
Algent approved these changes Jun 18, 2026
View reviewed changes

@Algent Algent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

LazyFlesh
LazyFlesh approved these changes Jun 18, 2026
View reviewed changes

@LazyFlesh LazyFlesh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder, can we do it twice?

TotallyNotOndre
TotallyNotOndre approved these changes Jun 19, 2026
View reviewed changes

@TotallyNotOndre TotallyNotOndre left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can

VortexSo4
VortexSo4 approved these changes Jun 19, 2026
View reviewed changes

@VortexSo4 VortexSo4 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does't increase the counter tho

@Dream-Master
Dream-Master merged commit 335bc6e into master Jun 19, 2026
1 check passed
@Dream-Master
Dream-Master deleted the remove-filth branch June 19, 2026 05:34
@FourIsTheNumber FourIsTheNumber mentioned this pull request Jun 30, 2026
Closed
3 tasks
@PLASMAchicken PLASMAchicken mentioned this pull request Jul 16, 2026
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algent Algent Algent approved these changes
@tiffit tiffit tiffit approved these changes
@koolkrafter5 koolkrafter5 koolkrafter5 approved these changes
@Luca-Guettinger Luca-Guettinger Luca-Guettinger approved these changes
@LazyFlesh LazyFlesh LazyFlesh approved these changes
@TotallyNotOndre TotallyNotOndre TotallyNotOndre approved these changes
@MalTeeez MalTeeez MalTeeez approved these changes
@Ruling-0 Ruling-0 Ruling-0 approved these changes
@ah-OOG-ah ah-OOG-ah ah-OOG-ah approved these changes
@RecursivePineapple RecursivePineapple RecursivePineapple approved these changes
@UltraProdigy UltraProdigy UltraProdigy approved these changes
@VortexSo4 VortexSo4 VortexSo4 approved these changes
@Auynonymous Auynonymous Auynonymous approved these changes
@thehoblit thehoblit thehoblit approved these changes

Assignees

No one assigned

Labels

Bug Fix Fixes a bug. Please link it in the PR if an issue exists for it. Refactor For PRs rewriting a part of the code to have a nicer code overall.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.