Skip to content

fix(web-ui): agent companion pet tap vs drag; persist turns only on quit#665

Merged
GCWing merged 1 commit into
mainfrom
gcwing/dev
May 11, 2026
Merged

fix(web-ui): agent companion pet tap vs drag; persist turns only on quit#665
GCWing merged 1 commit into
mainfrom
gcwing/dev

Conversation

@GCWing
Copy link
Copy Markdown
Owner

@GCWing GCWing commented May 11, 2026

Summary

  • Desktop pet: Distinguish a short primary click (show main window via \show_main_window) from dragging the pet to move the window, using a small movement threshold and pointer capture.
  • Window close / tray: Call \saveAllInProgressTurns\ only when the user actually quits, not when the main window is hidden to tray or macOS dock. Hiding had been settling in-flight turns and clearing Agent companion desktop bubbles prematurely.
  • Docs: Clarify in \PersistenceModule\ that \saveAllInProgressTurns\ is for process exit, not for hide-to-tray.

Testing

  • Manual: click pet without moving → main window shows.
  • Manual: drag pet past threshold → window moves as before.
  • Manual: hide main window to tray/dock with active bubbles → bubbles remain until next chat update.
  • Manual: quit from close dialog → in-progress turns still persisted.

…y on quit

- Resolve short clicks vs native drag on agent companion pet (threshold + pointer capture).
- Defer saveAllInProgressTurns until user actually quits, not when hiding to tray/dock,
  so desktop pet bubbles are not cleared on window hide.
- Document PersistenceModule contract for saveAllInProgressTurns.
@GCWing GCWing merged commit 752c6be into main May 11, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant