Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the climate preset handling to avoid sending heated/ventilated seat commands that the target vehicle hardware can’t support, preventing remote-start failures for certain built-in presets (notably “Full Cool”).
Changes:
- Sanitize fetched climate presets by stripping unsupported front-seat heat/cool values based on vehicle feature flags.
- Add new Subaru API feature constants for remote heated and ventilated front seats.
- Bump version from
0.7.21rc0to0.7.21rc1.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
subarulink/controller.py |
Sanitizes seat heat/cool fields in fetched presets based on vehicle capabilities before caching/using them. |
subarulink/_subaru_api/const.py |
Adds feature-flag constants used to detect heated/ventilated seat support. |
subarulink/__version__.py |
Increments package version to 0.7.21rc1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
…gering reset_session
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
20 tasks
jpettitt
added a commit
to jpettitt/home-assistant-core
that referenced
this pull request
Jun 28, 2026
Per codeowner feedback on PR home-assistant#174054: - Add the fourth VEHICLE_STATE value (ENGINE_ON_REMOTE_START) extracted from the Subaru Android app source (G-Two/subarulink#121). - Drop the disabled-by-default vehicle_state_raw companion sensor — with the full enum now confirmed, the existing diagnostics dump is sufficient for discovering any future unmapped values, and the codeowner explicitly preferred fewer entities. - Update the unmapped-value test to assert only the ENUM → `unknown` fallthrough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.7.21 also includes changes not part of this PR (already directly committed to master branch - this branch was created late)