Skip to content

v0.7.21#121

Open
G-Two wants to merge 12 commits into
masterfrom
v0.7.21
Open

v0.7.21#121
G-Two wants to merge 12 commits into
masterfrom
v0.7.21

Conversation

@G-Two

@G-Two G-Two commented Jun 27, 2026

Copy link
Copy Markdown
Owner

v0.7.21 also includes changes not part of this PR (already directly committed to master branch - this branch was created late)

  • Bump MySubaru API to 'g2v33'
  • Handle device not authenticated during remote command
  • Bubble up rejection reason from data.errorCode
  • Refactoring to remove network calls for certain feature checks
  • Fixed null odometer crash when odometer data is absent from API response
  • Fixed bad sensor sentinel values (16383) being stored for fuel consumption and range fields instead of retaining the last valid reading
  • Fixed GPS location data being silently corrupted when a bad location fix was received
  • Fixed EV range being incorrectly overwritten when battery charge was below 20%
  • Fixed zero remaining fuel being discarded due to a falsy check
  • Fixed remote command polling loop that could run indefinitely on repeated 403/invalid-token errors
  • Fixed climate preset operations mutating the caller's data structures
  • Fixed update_user_climate_presets logic error that caused valid presets to be overwritten
  • Fixed SubaruException silently dropping the error message before passing it to the base class
  • Fixed timezone-naive datetime sentinels for last fetch/update timestamps
  • Fixed get_api_gen returning the wrong generation when multiple generation flags were present
  • Fixed HTTP error exceptions carrying only a status code integer with no message
  • stdiomask moved to optional [cli] dependency — no longer installed for non-CLI users
  • Remote command polling now uses exponential backoff (2 s → 15 s cap) instead of a fixed 2 s interval
  • Minimum Python version raised to 3.14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the climate preset handling to avoid sending heated/ventilated seat commands that the target vehicle hardware can’t support, preventing remote-start failures for certain built-in presets (notably “Full Cool”).

Changes:

  • Sanitize fetched climate presets by stripping unsupported front-seat heat/cool values based on vehicle feature flags.
  • Add new Subaru API feature constants for remote heated and ventilated front seats.
  • Bump version from 0.7.21rc0 to 0.7.21rc1.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
subarulink/controller.py Sanitizes seat heat/cool fields in fetched presets based on vehicle capabilities before caching/using them.
subarulink/_subaru_api/const.py Adds feature-flag constants used to detect heated/ventilated seat support.
subarulink/__version__.py Increments package version to 0.7.21rc1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread subarulink/controller.py
Comment thread subarulink/controller.py

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comment thread subarulink/controller.py
Comment thread subarulink/connection.py
Copilot finished work on behalf of G-Two June 27, 2026 20:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comment thread subarulink/controller.py
jpettitt added a commit to jpettitt/home-assistant-core that referenced this pull request Jun 28, 2026
Per codeowner feedback on PR home-assistant#174054:
- Add the fourth VEHICLE_STATE value (ENGINE_ON_REMOTE_START) extracted
  from the Subaru Android app source (G-Two/subarulink#121).
- Drop the disabled-by-default vehicle_state_raw companion sensor — with
  the full enum now confirmed, the existing diagnostics dump is
  sufficient for discovering any future unmapped values, and the
  codeowner explicitly preferred fewer entities.
- Update the unmapped-value test to assert only the ENUM → `unknown`
  fallthrough.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants