Channel properties editor, per-channel scaling, and dependency/toolchain updates#19
Merged
Conversation
Rework the Manage Channels window into a table (color/name, Scale, Min, Max, Edit) with a per-channel Channel Properties editor for color, display unit, and display scaling (Auto or Manual min/max). Manual display limits feed compute_y_range and persist through both workspace layouts and global channel preferences. Claude-Session: https://claude.ai/code/session_01GqtMqnvwF85US9q9Q8P7Jo
Dependencies: - egui stack 0.34 -> 0.35 (eframe/egui 0.35, egui_plot 0.36, egui_dock 0.20) - quick-xml 0.39 -> 0.41, pollster 0.4 -> 1.0, gloo-timers 0.3 -> 0.4 - criterion 0.5 -> 0.8 (dev); plus semver-compatible lockfile updates Fixes for Rust 1.97: - Annotate float literals for the new f32-fallback future-incompat lint - Rename deprecated egui Panel::show_inside -> show - Switch bench black_box to std::hint::black_box App: - Per-channel manual/auto Y-scale with saved scale limits in workspaces Versioning: - Crate 0.2.1 -> 0.3.0, app 0.5.0 -> 0.6.0 - Add AGENTS.md mirroring CLAUDE.md Claude-Session: https://claude.ai/code/session_01GqtMqnvwF85US9q9Q8P7Jo
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d1033cf43b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clippy -D warningsgreen):egui::Panel::show_inside→showblack_box→std::hint::black_boxAGENTS.mdmirroringCLAUDE.md.Release impact
Both version streams are bumped, so merging to main will trigger a crates.io publish (
v0.3.0) and a desktop app release (app-v0.6.0).Verification
cargo clippy --workspace --all-targets -- -D warnings— passcargo test --workspace— passcargo fmt --check— passcargo check --target wasm32-unknown-unknown— passNot done: a manual GUI smoke test of the egui 0.35 upgrade is still recommended before merge.
https://claude.ai/code/session_01GqtMqnvwF85US9q9Q8P7Jo