Fix framebuffer image memory retention#242
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes framebuffer frames retaining high RSS after rendering large local photos.
render/imagesource image fields afterrunandget.malloc_trim(0)after each draw so freed decode/scale memory can return to the OS.Root Cause
The local image scene decodes full-size photos before scaling them to the framebuffer. On HDMI framebuffer targets with the Pixie engine, large decoded source images and allocator high-water memory could keep process RSS near the systemd memory limit after each render. Later large images then pushed
frameosinto OOM. E-ink devices were less affected because their render cadence/path differs.Impact
Framebuffer frames that cycle through large local images should return to a lower memory baseline after each render instead of gradually sitting near
MemoryMax. The forced reclamation is scoped todevice == "framebuffer"to avoid adding GC work to other driver paths.Validation
nim c -r src/apps/render/image/tests/test_app.nimnim c -r src/apps/data/localImage/tests/test_app.nimnim c -r src/frameos/tests/test_runner_loop.nimnim check --os:linux src/frameos/utils/memory.nimnim c --compileOnly -d:malloc --nimcache:.nimcache/frameos_check_malloc src/frameos.nim