feat: add on-chain cooling off period for like action (SC-038)#498
Open
Mirabel64 wants to merge 1 commit into
Open
feat: add on-chain cooling off period for like action (SC-038)#498Mirabel64 wants to merge 1 commit into
Mirabel64 wants to merge 1 commit into
Conversation
Implement SC-038: prevent the same user from liking the same transaction more than once within a 5-ledger window (~25s). - Add LIKE_COOLDOWN_LEDGERS constant (5 ledgers) - Store (tx_id, sender) -> last_ledger in temporary storage - Reject rapid duplicate likes via assert! - Extend TTL to ~1 day for temporary entries - Add tests: cooldown allows after period, different users not affected - Update existing like test to set ledger sequence
|
@Mirabel64 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements SC-038: Adds an on-chain cooling-off period that prevents the same user from liking the same transaction more than once within a 5-ledger window (~25 seconds on Stellar).
Changes Made
LIKE_COOLDOWN_LEDGERS = 5: New constant defining the cooldown windowlike_payment(): Now stores(tx_id, sender) -> last_ledgerin temporary storage and rejects rapid duplicate likes viaassert!test_like_payment_cooling_off_allows_after_cooldown— verifies likes work after the cooldown expirestest_like_payment_different_users_not_affected— verifies cooldown is per-user, not per-transactiontest_like_payment_emits_eventto set ledger sequenceTesting
All 9 tests pass (5 ignored are pre-existing SDK compatibility issues unrelated to this change).
Closes #442