Skip to content

fix(rpc datasource): handle correctly simple action response#306

Merged
arnaud-moncel merged 1 commit into
mainfrom
fix/rpc/action-response
May 21, 2026
Merged

fix(rpc datasource): handle correctly simple action response#306
arnaud-moncel merged 1 commit into
mainfrom
fix/rpc/action-response

Conversation

@arnaud-moncel
Copy link
Copy Markdown
Member

@arnaud-moncel arnaud-moncel commented May 20, 2026

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

Note

Fix execute in RPC datasource collection to symbolize keys in action responses

Adds symbolize_keys: true to the @client.call_rpc call in Collection#execute so that action responses are returned with symbol keys (including :type) instead of string keys. Two new specs in collection_spec.rb verify that the option is passed and that the result is returned unchanged.

Macroscope summarized 9508918.

Copy link
Copy Markdown
Member

@matthv matthv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaud-moncel arnaud-moncel merged commit acf3ec7 into main May 21, 2026
44 checks passed
@arnaud-moncel arnaud-moncel deleted the fix/rpc/action-response branch May 21, 2026 08:28
forest-bot added a commit that referenced this pull request May 21, 2026
## [1.30.2](v1.30.1...v1.30.2) (2026-05-21)

### Bug Fixes

* **rpc datasource:** handle correctly simple action response ([#306](#306)) ([acf3ec7](acf3ec7))
@forest-bot
Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.30.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants