Skip to content

fix: action with file#305

Merged
arnaud-moncel merged 1 commit into
mainfrom
fix/action-file
May 20, 2026
Merged

fix: action with file#305
arnaud-moncel merged 1 commit into
mainfrom
fix/action-file

Conversation

@arnaud-moncel
Copy link
Copy Markdown
Member

@arnaud-moncel arnaud-moncel commented May 20, 2026

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

Note

Fix file action results to include correct type and expose Content-Disposition header

  • Fixes ActionResult.parse in action_result.rb to include type: 'File' in the parsed hash and read the payload from :stream instead of :content.
  • Adds Access-Control-Expose-Headers: Content-Disposition to file responses in ForestController#forest_response so cross-origin clients can read the Content-Disposition header.

Macroscope summarized d948200.

Copy link
Copy Markdown
Member

@matthv matthv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean fix 🏅

@arnaud-moncel arnaud-moncel merged commit c7f8af3 into main May 20, 2026
44 checks passed
@arnaud-moncel arnaud-moncel deleted the fix/action-file branch May 20, 2026 14:51
forest-bot added a commit that referenced this pull request May 20, 2026
## [1.30.1](v1.30.0...v1.30.1) (2026-05-20)

### Bug Fixes

* action with file ([#305](#305)) ([c7f8af3](c7f8af3))
@forest-bot
Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.30.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants