fix(workflow): replace automatedExecution with executionType by EnkiP · Pull Request #1590 · ForestAdmin/agent-nodejs

EnkiP · 2026-05-21T11:13:29Z

Definition of Done

fixes PRD-378

need frontend PR: https://github.com/ForestAdmin/forestadmin/pull/9708
and backend PR: https://github.com/ForestAdmin/forestadmin-server/pull/8254
branch name is always fix/execution-type

General

Write an explicit title for the Pull Request, following Conventional Commits specification
Test manually the implemented changes
Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

Consider the security impact of the changes made

Note

[!NOTE]

Replace `automaticExecution` with `executionType` enum across workflow step executors

Removes the automaticExecution boolean from all step schemas in step-definition.ts and replaces it with an optional executionType enum (ServerStepExecutionTypeEnum: FullyAutomated, AutomatedWithConfirmation, Manual).
Updates all executors (TriggerRecordActionStepExecutor, UpdateRecordStepExecutor, LoadRelatedRecordStepExecutor, McpStepExecutor) to branch on executionType === FullyAutomated instead of automaticExecution.
Adds manual execution handling to ConditionStepExecutor: when executionType=Manual and no incoming pending data exists, the step returns awaiting-input without calling the AI.
Changes the default polling interval in build-workflow-executor.ts from 5000 ms to 30000 ms.
Risk: automaticExecution is no longer accepted in step definitions; any callers still passing this field will have it ignored or fail schema validation.

Changes since #1590 opened

Replaced ServerStepExecutionTypeEnum with StepExecutionMode enum throughout workflow-executor package [77f5301]
Added warn method to Logger interface and all logger implementations and test mocks [77f5301]
Implemented unsupported execution type warning feature in step executors [77f5301]

^{Macroscope summarized 851e5ee.}

qltysh · 2026-05-21T11:14:41Z

2 new issues

Tool	Category	Rule	Count
qlty	Structure	Function with many returns (count = 4): toStepOutcome	2

linear · 2026-05-21T12:33:26Z

PRD-378

qltysh · 2026-05-21T12:36:35Z

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on feat/prd-214-server-step-mapper by 0.01%.

Modified Files with Diff Coverage (15)

File	% Diff	Uncovered Line #s
packages/workflow-executor/src/adapters/console-logger.ts	0.0%	9
...ow-executor/src/executors/load-related-record-step-executor.ts	100.0%
packages/workflow-executor/src/build-workflow-executor.ts	100.0%
packages/workflow-executor/src/adapters/pretty-logger.ts	0.0%	15
...s/workflow-executor/src/executors/read-record-step-executor.ts	100.0%
...ges/workflow-executor/src/executors/condition-step-executor.ts	100.0%
packages/workflow-executor/src/executors/base-step-executor.ts	100.0%
...workflow-executor/src/executors/update-record-step-executor.ts	100.0%
...-executor/src/executors/trigger-record-action-step-executor.ts	100.0%
...workflow-executor/src/adapters/run-to-available-step-mapper.ts	100.0%
packages/workflow-executor/src/types/validated/step-definition.ts	100.0%
packages/workflow-executor/src/executors/mcp-step-executor.ts	100.0%
packages/workflow-executor/src/adapters/step-definition-mapper.ts	100.0%
...ages/workflow-executor/src/executors/guidance-step-executor.ts	100.0%
packages/workflow-executor/src/adapters/server-types.ts	100.0%
Total	96.7%

🤖 Increase coverage with AI coding...

In the `fix/execution-type` branch, add test coverage for this new code:

- `packages/workflow-executor/src/adapters/console-logger.ts` -- Line 9
- `packages/workflow-executor/src/adapters/pretty-logger.ts` -- Line 15

🚦 See full report on Qlty Cloud »

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Scra3

Good direction on the enum migration. A few architectural and documentation points before merge.

Scra3 · 2026-05-21T13:10:51Z


 import { z } from 'zod';

+import { ServerStepExecutionTypeEnum } from '../../adapters/server-types';


issue (non-blocking): ServerStepExecutionTypeEnum from the adapter layer leaks into the domain schema — declare a StepExecutionMode enum here in types/validated/ instead and have step-definition-mapper.ts be the single translation point. Executors should import from types/validated/, never from adapters/.

Scra3 · 2026-05-21T13:10:51Z

-const baseRecordFields = {
-  ...baseFields,
-  automaticExecution: z.boolean().optional(),
+  executionType: z.enum(ServerStepExecutionTypeEnum).optional(),


nit: z.enum() is designed for string-tuple arrays; z.nativeEnum(StepExecutionMode) is the idiomatic form for TypeScript enum objects — use it once the domain enum is declared above.

what about the commentary: Use z.enum(EnumObject), not z.nativeEnum — the latter is deprecated in zod 4.

Scra3 · 2026-05-21T13:10:51Z

    }

-    // Branch C -- Awaiting confirmation
+    // Branch C -- Awaiting confirmation (also covers Manual fallback)


issue (non-blocking): also covers Manual fallback hides an intentional design choice — document explicitly that manual and automatedWithConfirmation share Branch C because the AI suggestion is always computed and the distinction is UI-only (how the front presents the confirmation to the user).

Also, add a warning logs if we receive "manual". Add it on each step

Scra3 · 2026-05-21T13:10:51Z

    }

-    // Branch C -- pre-fetch candidates, await user confirmation
+    // Branch C -- pre-fetch candidates, await user confirmation (also covers Manual fallback)


issue (non-blocking): same as update-record — document why manual and automatedWithConfirmation intentionally share Branch C.

Scra3 · 2026-05-21T13:10:51Z

    }

-    // Branch C -- Awaiting confirmation (frontend executes the action, including forms)
+    // Branch C -- Awaiting confirmation (frontend executes the action, including forms).


issue (non-blocking): same — document the intentional equivalence of manual and automatedWithConfirmation in Branch C.

Scra3 · 2026-05-21T13:10:51Z

    }

-    // Branch C -- Awaiting confirmation
+    // Branch C -- Awaiting confirmation (also covers Manual fallback)


issue (non-blocking): same — document the intentional equivalence of manual and automatedWithConfirmation in Branch C.

Enki Pontvianne added 2 commits May 21, 2026 12:13

fix(workflow): replace automatedExecution with executionType

49ad16d

fix: tests

e6767f1

Enki Pontvianne added 2 commits May 21, 2026 13:18

fix: merge main branch

a31ed9a

fix: tests

851e5ee

Scra3 reviewed May 21, 2026

View reviewed changes

Comment thread packages/workflow-executor/src/executors/base-step-executor.ts

Scra3 reviewed May 21, 2026

View reviewed changes

Enki Pontvianne added 2 commits May 21, 2026 15:22

fix(review): log warnings when executionType is not supported

a3e5390

fix: review

77f5301

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(workflow): replace automatedExecution with executionType#1590

fix(workflow): replace automatedExecution with executionType#1590
EnkiP wants to merge 6 commits into
feat/prd-214-server-step-mapperfrom
fix/execution-type

EnkiP commented May 21, 2026 •

edited by macroscopeapp Bot

Loading

Uh oh!

qltysh Bot commented May 21, 2026

Uh oh!

linear Bot commented May 21, 2026

Uh oh!

qltysh Bot commented May 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Scra3 left a comment

Uh oh!

Scra3 May 21, 2026

Uh oh!

Scra3 May 21, 2026

Uh oh!

EnkiP May 21, 2026

Uh oh!

Scra3 May 21, 2026

Uh oh!

Scra3 May 21, 2026

Uh oh!

Scra3 May 21, 2026

Uh oh!

Scra3 May 21, 2026

Uh oh!

Scra3 May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		import { z } from 'zod';

		import { ServerStepExecutionTypeEnum } from '../../adapters/server-types';

Conversation

EnkiP commented May 21, 2026 • edited by macroscopeapp Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Definition of Done

General

Security

Replace automaticExecution with executionType enum across workflow step executors

Changes since #1590 opened

Uh oh!

qltysh Bot commented May 21, 2026

Uh oh!

linear Bot commented May 21, 2026

Uh oh!

qltysh Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Scra3 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

EnkiP commented May 21, 2026 •

edited by macroscopeapp Bot

Loading

Replace `automaticExecution` with `executionType` enum across workflow step executors

qltysh Bot commented May 21, 2026 •

edited

Loading