feat: only track exposure when experiment feature is enabled#226
Merged
Conversation
get_experiment_flag now skips the exposure event when the resolved flag is disabled, in addition to the existing DefaultFlag skip, to keep experimentation data clean.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the get_experiment_flag method in flagsmith/flagsmith.py to skip tracking exposure events when the resolved feature flag is disabled. A corresponding unit test has been added to verify this behavior. There are no review comments, and I have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_experiment_flagnow skips the exposure event when the resolved flag is disabledChanges
get_experiment_flagguard changed fromisinstance(flag, Flag)toisinstance(flag, Flag) and flag.enabled.test_get_experiment_flag_skips_exposure_for_disabled_featurecovering a disabled flag (with a variant set, to prove theenabledcheck is what gates tracking).Testing
poetry run pytest tests/test_flagsmith.py -k experiment_flag— 6 passed.