Fix EU event-log fallback to query EU host#16
Merged
Conversation
subscribeToChanges correctly routes the WebSocket to wss://ws-eu.fastcomments.com for EU tenants, but the "fetch missed events" REST fallback always built its PublicApi against the default host (https://fastcomments.com). For EU tenants that silently queried US infra and returned nothing, so events missed while disconnected were never replayed. Thread config.region into fetchEventLog and point the ApiClient at https://eu.fastcomments.com when region is "eu".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
subscribeToChangescorrectly routes the live WebSocket towss://ws-eu.fastcomments.comfor EU tenants (config.region == "eu"), but the "fetch missed events" REST fallback (fetchEventLog) always built itsPublicApiagainst the default hosthttps://fastcomments.com:For EU tenants this silently queries US infra and gets nothing back, so any events missed while disconnected (the whole point of the fallback) are never replayed.
Fix
Thread
config.regionintofetchEventLogand point theApiClientathttps://eu.fastcomments.comwhen the region is"eu"(the EU host already exists in the generated client's server list).Testing
:pubsub:compileJavabuilds cleanly against the local client via the CI init script:Notes
The same bug was found and fixed in the Python SDK; this brings the Java SDK in line for EU tenants.