Add proper support for escape manipulation by Actions#1047
Open
Robotgiggle wants to merge 14 commits into
Open
Add proper support for escape manipulation by Actions#1047Robotgiggle wants to merge 14 commits into
Robotgiggle wants to merge 14 commits into
Conversation
object-Object
requested changes
May 14, 2026
Member
object-Object
left a comment
object-Object
left a comment
There was a problem hiding this comment.
Didn't fully review (am on a phone), but skimmed and noticed some problematic breaking changes.
github-project-automation
Bot
moved this from 📋 Backlog
to 🏗 In progress
in Hex Casting
Robotgiggle
force-pushed
the
paren-refactor
branch
from
fb56cc9 to
6b605c9
Compare
object-Object
requested changes
May 27, 2026
Member
object-Object
left a comment
object-Object
left a comment
There was a problem hiding this comment.
This is coming along! Overall this change looks pretty good, and it's nice to make the VM less hardcoded; however, there are some things in the API that could be cleaned up, as well as some potential refactors and documentation improvements.
Member
There was a problem hiding this comment.
Should we also document that Hasty Retrospection was renamed to Absent Introspection?
Robotgiggle
force-pushed
the
paren-refactor
branch
from
f0a0e0b to
76b3118
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
operateInParensmethod to allowActions to define custom behavior when executed inside parentheses, and removes all the hardcoded jank that was used to do this before.This enables the previously hardcoded patterns for escape manipulation (Consideration, Introspection, Retrospection, and Evanition) to be turned into normal
Actions, and also makes it possible to add new escape manipulators in addons or future updates.Also fixes #1077 by allowing Evanition to undo the opening Introspection if there's nothing else to undo.