Allow builds without github.properties - #14
Open
masaru87 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.propertiesonly when the file existsTOKENinstead ofUSERNAMEfor the GitHub Packages password fallbackWhy
github.propertiesis gitignored, but the settings and publishing configuration currently open it unconditionally. As a result, a fresh clone fails during Gradle configuration before any task can run. The GitHub Actions workflows avoid the failure by creating an empty file first.This keeps the existing properties-file and environment-variable credential paths while allowing tasks that do not need GitHub Packages credentials to run from a fresh clone.
Verification
./gradlew jvmTest --no-daemonwithoutgithub.propertiesorTOKEN