feat: Use commit string from runtime/debug if built without goreleaser. - #135
Merged
Conversation
Via prometheus/common/version to keep the change trivial.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CLI version command to display a commit SHA derived from Go build metadata when the binary wasn’t built with commit ldflags (e.g., local go build), using github.com/prometheus/common/version as the implementation source.
Changes:
- Import
github.com/prometheus/common/versionand use it to populatecommitwhen not injected at build time. - Change the default
commitvalue from"none"to""to enable an “unset” sentinel. - Add runtime fallback logic in the
versionsubcommand execution path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
As suggested by copilot. Co-authored-by: Copilot Autofix powered by AI <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Via prometheus/common/version to keep the change trivial.