feat(mpd): add WriteXML and Period.Write/WriteToString#56
Merged
Conversation
Extract the encoder logic from (*MPD).Write into an exported WriteXML that serializes any element, and add Period.Write/WriteToString for writing a single Period fragment. Add tests and clean up doc comments.
It flags pre-existing repeated string literals across the package (mostly test fixtures) without enough value to justify the churn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(*MPD).Writeinto an exportedWriteXML(elem any, w io.Writer, indent string, withHeader bool)that canserialize any element.
(*MPD).Writenow delegates to it.(*Period).Write(w, indent)and(*Period).WriteToString(indent)forserializing a single
Periodfragment (no XML declaration).goconstlinter, which only flagged pre-existing repeated stringliterals (mostly test fixtures) across the package.
Tests
Added to
mpd/io_test.go:TestWriteXML—WriteXMLand(*MPD).Writeproduce identical output, thereturned byte count matches bytes written, and
withHeadertoggles the<?xmldeclaration.TestPeriodWriteToString/TestPeriodWrite— a bare<Period>fragmentrenders with the expected attributes and no XML declaration, and
Writeagrees with
WriteToString.go test ./mpd/andgo vet ./mpd/are green.CHANGELOG
Added an
Addedentry under[Unreleased].🤖 Generated with Claude Code