Skip to content

Fix split-cache stale worker lock reclaim#2358

Merged
chubes4 merged 1 commit into
mainfrom
fix/stale-worker-lock-cache-split
May 28, 2026
Merged

Fix split-cache stale worker lock reclaim#2358
chubes4 merged 1 commit into
mainfrom
fix/stale-worker-lock-cache-split

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented May 28, 2026

Summary

  • complete stale worker lock reclaim for cases where delete/add leaves the local snapshot unlocked while the persistent option still blocks add_option()
  • replace the option whenever the post-delete snapshot is not actively held by another worker
  • add smoke coverage for the split-cache stale option path observed on intelligence.horse

Verification

  • php tests/worker-lock-smoke.php
  • homeboy lint --path /Users/chubes/Developer/data-machine@fix-stale-worker-lock-cache-split --extension wordpress --file inc/Cli/WorkerLock.php --errors-only

Runtime context

Follow-up to #2355. The live intelligence.horse worker still saw a stale lock but exited locked because add_option failed while the post-delete snapshot no longer reported stale.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Diagnosed the remaining live stale lock reclaim edge case, drafted the lock acquisition fix and smoke coverage, and ran targeted verification for Chris to review.

@homeboy-ci
Copy link
Copy Markdown
Contributor

homeboy-ci Bot commented May 28, 2026

Homeboy Results — data-machine

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
Deep dive: homeboy lint data-machine --changed-since b2904ac

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26608005684

Test

test — passed

  • 102 passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine --from lint --write
ℹ️ Collect coverage: homeboy test data-machine --coverage
ℹ️ Save test baseline: homeboy test data-machine --baseline
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine --changed-since b2904ac

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26608005684

Audit

audit — passed

  • requested_detectors — 3 finding(s)
  • Total: 3 finding(s)

Deep dive: homeboy audit data-machine --changed-since b2904ac

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26608005684
Tooling versions
  • Homeboy CLI: homeboy 0.201.3+2ddde1dc
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 059d2aae
  • Action: unknown@unknown

@chubes4 chubes4 merged commit 3dbad52 into main May 28, 2026
5 checks passed
@chubes4 chubes4 deleted the fix/stale-worker-lock-cache-split branch May 28, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant