Skip to content

ci: consistently use latest cache-apt-pkgs-action for ffmpeg#822

Open
joanise wants to merge 2 commits into
dev.ej/ci-bump-uvfrom
dev.ej/ci-awalsh-cache-test
Open

ci: consistently use latest cache-apt-pkgs-action for ffmpeg#822
joanise wants to merge 2 commits into
dev.ej/ci-bump-uvfrom
dev.ej/ci-awalsh-cache-test

Conversation

@joanise

@joanise joanise commented Jun 15, 2026

Copy link
Copy Markdown
Member

PR Goal?

FedericoCarboni is an unstable way to install ffmpeg on Linux. awalsh128/cache-apt-pkgs-action, on the other hand, is fast and (mostly) reliable, with a small bug fix to make it work consistently.

Instead of trying one way, which sometimes fails, and then trying a second slower way, let's always use the reliable apt install, with caching to make it fast (most of the time, i.e., on cache hits).

Also bump cache-apt-pkgs-action to the latest version with node 24 in sub actions--it was actually this bump to threw me down the rabbit hole, with CI failing is weird and unexpected ways.

Fixes?

Speed and reliability of ffmpeg installation in CI

Feedback sought?

please review my updated workflow carefully, though I'm quite confident

Priority?

normal

Tests added?

it's just for testing

How to test?

see CI pass more reliably and faster than before

Confidence?

pretty high

Version change?

no

Related PRs?

EveryVoiceTTS/FastSpeech2_lightning#145

Builds on #820 and #821

PS

Never mind all those commits, I'll squash before or upon merging

@semanticdiff-com

semanticdiff-com Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  .github/workflows/matrix-tests.yml  17% smaller
  .github/workflows/test.yml  15% smaller
  everyvoice/model/feature_prediction/FastSpeech2_lightning  0% smaller

@joanise joanise requested a review from roedoejet June 15, 2026 16:04
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor
CLI load time: 0:00.29
Pull Request HEAD: af4d2de35dbd78c1f140fa52c3728d49b8c0e2d5

Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:     50434 |     113508 |         difflib
import time:      4908 |     118415 |       typer.core
import time:      7421 |     182758 |     typer.main
import time:       991 |     235019 |   typer
import time:     42647 |     112290 |         multiprocessing.context
import time:     58665 |     170955 |       multiprocessing
import time:      1015 |     171969 |     everyvoice.base_cli.interfaces
import time:      1792 |     174043 |   everyvoice.base_cli.checkpoint
import time:     20863 |     279177 |                     asyncio.base_events
import time:     21078 |     349795 |                   asyncio
import time:       374 |     350169 |                 loguru._asyncio_loop
import time:      5825 |     452149 |               loguru._logger
import time:      3760 |     457105 |             loguru
import time:      2452 |     550012 |           everyvoice.utils
import time:       882 |     550893 |         everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli.benchmark
import time:       541 |     559312 |       everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli.cli
import time:       325 |     559636 |     everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli
import time:      1289 |     560925 |   everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli.check_data
import time:      7396 |    1131457 | everyvoice.cli
import time:     70949 |     164802 |             importlib.metadata
import time:       456 |     165258 |           pygments.plugin
import time:      3758 |     172336 |         pygments.filters
import time:      4566 |     178957 |       pygments.lexer
import time:      6244 |     205426 |     rich.syntax
import time:      5145 |     303135 |   rich.markdown
import time:      4288 |     389708 | typer.rich_utils

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.99%. Comparing base (0ae89d9) to head (af4d2de).

Additional details and impacted files
@@                Coverage Diff                 @@
##           dev.ej/ci-bump-uv     #822   +/-   ##
==================================================
  Coverage              84.99%   84.99%           
==================================================
  Files                     46       46           
  Lines                   4219     4219           
  Branches                 632      632           
==================================================
  Hits                    3586     3586           
  Misses                   494      494           
  Partials                 139      139           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joanise joanise changed the title Dev.ej/ci awalsh cache test ci: consistently use latest cache-apt-pkgs-action for ffmpeg Jun 15, 2026
joanise added a commit that referenced this pull request Jun 15, 2026
 - with workaround for bug installing ffmpeg from cache hits
 - with bump for awalsh128/cache-apt-pkgs-action to latest version for
   indirect node 24 bumps
@joanise joanise force-pushed the dev.ej/ci-awalsh-cache-test branch from 202bb29 to c5a40e7 Compare June 15, 2026 16:16
@joanise joanise force-pushed the dev.ej/ci-bump-uv branch from 2e31d7d to 0ae89d9 Compare June 15, 2026 18:33
joanise added 2 commits June 15, 2026 14:33
 - with workaround for bug installing ffmpeg from cache hits
 - with bump for awalsh128/cache-apt-pkgs-action to latest version for
   indirect node 24 bumps
@joanise joanise force-pushed the dev.ej/ci-awalsh-cache-test branch from c5a40e7 to af4d2de Compare June 15, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants