ci: consistently use latest cache-apt-pkgs-action for ffmpeg#822
Open
joanise wants to merge 2 commits into
Open
ci: consistently use latest cache-apt-pkgs-action for ffmpeg#822joanise wants to merge 2 commits into
joanise wants to merge 2 commits into
Conversation
Changed Files
|
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev.ej/ci-bump-uv #822 +/- ##
==================================================
Coverage 84.99% 84.99%
==================================================
Files 46 46
Lines 4219 4219
Branches 632 632
==================================================
Hits 3586 3586
Misses 494 494
Partials 139 139 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
joanise
added a commit
that referenced
this pull request
Jun 15, 2026
- with workaround for bug installing ffmpeg from cache hits - with bump for awalsh128/cache-apt-pkgs-action to latest version for indirect node 24 bumps
202bb29 to
c5a40e7
Compare
roedoejet
approved these changes
Jun 15, 2026
2e31d7d to
0ae89d9
Compare
- with workaround for bug installing ffmpeg from cache hits - with bump for awalsh128/cache-apt-pkgs-action to latest version for indirect node 24 bumps
c5a40e7 to
af4d2de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
FedericoCarboni is an unstable way to install ffmpeg on Linux. awalsh128/cache-apt-pkgs-action, on the other hand, is fast and (mostly) reliable, with a small bug fix to make it work consistently.
Instead of trying one way, which sometimes fails, and then trying a second slower way, let's always use the reliable apt install, with caching to make it fast (most of the time, i.e., on cache hits).
Also bump cache-apt-pkgs-action to the latest version with node 24 in sub actions--it was actually this bump to threw me down the rabbit hole, with CI failing is weird and unexpected ways.
Fixes?
Speed and reliability of ffmpeg installation in CI
Feedback sought?
please review my updated workflow carefully, though I'm quite confident
Priority?
normal
Tests added?
it's just for testing
How to test?
see CI pass more reliably and faster than before
Confidence?
pretty high
Version change?
no
Related PRs?
EveryVoiceTTS/FastSpeech2_lightning#145
Builds on #820 and #821
PS
Never mind all those commits, I'll squash before or upon merging