Fix getting names all around#233
Open
Haselnussbomber wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a wrong assumption in PR #230 that BNpcBase ids are BNpcName ids, too.
This is not the case, so we need to include LuminaSupplemental, which provides a crowdsourced mapping between those. It should be updated every once and again.
The change to that also made manual BNpc name entries in the
Brio/Resources/Embedded/Data/NpcNames.jsonobsolete, so I removed those - just keeping manual ENpc name overrides.The bad news about this is that BNpcBases can have multiple BNpcName ids, and the other way around. I just let it pick the first that comes up.
I've added caches for names as there is some special logic with fallbacks and pre-filtered (
RowId != 0 && ModelChara.RowId != 0) row-arrays for common sheets, so that GameDataProvider provides it for every class that needs filtered lists.Sorry this PR got a bit bigger. I suggest reviewing with "No Whitespace" enabled.^^