Skip to content

feat: remove radeonsi hevc_vaapi workaround; ffmpeg 8.1.2 is fixed #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasongdove merged 1 commit into from
Jul 24, 2026
Merged

feat: remove radeonsi hevc_vaapi workaround; ffmpeg 8.1.2 is fixed #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions crates/ffpipeline/src/accel/vaapi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ impl HwAccel for Vaapi {
&self,
format: &VideoFormat,
bit_depth: u8,
video_size: Option<FrameSize>,
_video_size: Option<FrameSize>,
) -> Option<VideoCodec> {
let force_cqp = self.capabilities.rate_control_mode_for(format, bit_depth)
== Some(RateControlMode::Cqp);
Expand All @@ -224,14 +224,6 @@ impl HwAccel for Vaapi {
options.extend(args!["-rc_mode", "1"]);
}

// WORKAROUND: RadeonSI doesn't always output appropriate crop
// metadata with HEVC encoder; it doesn't hurt anything to always specify
if self.driver == VaapiDriver::RadeonSI
&& video_size.map(|s| s.height) == Some(1080)
{
options.extend(args!["-bsf:v", "hevc_metadata=crop_bottom=8"]);
}

Some(VideoCodec {
codec_name: "hevc_vaapi",
options,
Expand Down