Fix: Correct timestamp units in doc comments#141
Open
bclarke123 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ben Clarke <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Corrects documentation that describes timestamps as Unix epoch seconds when the values are actually milliseconds: the v1 proto comments (
Repository.created,Branch.created, thin-client commit timestamp), the generated C header, and the revision history--datehelp. Doc-only, no wire or on-disk values change.Why
The implementation is uniformly milliseconds end to end
util::time::timestamp(), the persisted revision-metadataTIMESTAMPkey, the server's cache-age math, the CLI'sfrom_timestamp_millisdisplays - so external consumers that trust the documented unit get values 1000× larger than promised (we hit this building a web frontend against the API and had to add a runtime unit-sniffing workaround).The
--dateflag is the one place this becomes a functional bug: passing epoch seconds as documented compares against millisecond values, so the filter silently never matches.Notes
last_accessgenuinely is seconds (as_secs()) and is left as-is.lore.hand prost output are regenerated, not hand-edited.