ci: Add PR validation workflow#132
Draft
ragnarula wants to merge 3 commits into
Draft
Conversation
ragnarula
force-pushed
the
feature/pr-validate
branch
from
July 20, 2026 13:08
7c1cc1b to
92f6b2a
Compare
Fan out the full test suite across every supported platform on public GitHub-hosted runners with no secrets: - unit: `cargo test --workspace` on linux (x86_64 + aarch64), macOS, and Windows. - integration: MinIO/DynamoDB-Local/Consul via Docker Compose, then `cargo test -p lore-integration-tests --features integration_tests` (Linux x86_64 only, as Docker is unavailable on hosted macOS/Windows). - smoke: build `lore` + `loreserver` (with the `failure_generator` feature) and run the `scripts/test` pytest suite via uv, on all four platforms. An aggregate `PR Validate` job gates on all of the above so branch protection can require a single check. Co-Authored-By: Claude Opus 4.8 <[email protected]> Signed-off-by: Raghav Narula <[email protected]>
ragnarula
force-pushed
the
feature/pr-validate
branch
from
July 20, 2026 13:12
92f6b2a to
86c286d
Compare
The full-workspace `cargo test` build embedded full DWARF into every test binary (split-debuginfo=off), so the linker held all of it in memory at once. On the 16 GB hosted ubuntu-24.04-arm runner that exhausted memory and the runner was terminated (SIGTERM, exit 143) mid-compile before any test ran, failing `unit (linux-aarch64)` while every other unit job passed. Packed emits a companion .dwp and keeps peak linker memory down. Co-Authored-By: Claude Opus 4.8 <[email protected]> Signed-off-by: Raghav Narula <[email protected]>
…nlint - Revert the aarch64-linux split-debuginfo=packed experiment back to =off; the release/server artifacts want embedded symbols, so the debug-info change is deferred rather than shipped here. - Comment out the linux-aarch64 unit matrix entry with a TODO. The full-workspace `cargo test` links every test binary with embedded DWARF (split-debuginfo=off), exhausting the 16 GB hosted arm64 runner; it is killed (SIGTERM/143) mid-compile before any test runs. Re-enable after switching that target's debug-info method (packed/unpacked or a line-tables-only test profile). Smoke still covers arm64. - Host the Linux smoke suites' working data on a 12 GB tmpfs (/dev/shm) via --basetemp. The suite writes ~10 GB of disk-I/O-heavy per-test state that pytest never cleans up mid-session; RAM-backing it speeds the I/O-bound tests. Sized above the observed footprint but below the 16 GB runner RAM. Linux only. - Add .github/actionlint.yaml whitelisting the ubuntu-24.04-arm runner label, which actionlint's bundled label list does not yet know, so the pre-commit actionlint hook stops failing. Co-Authored-By: Claude Opus 4.8 <[email protected]> Signed-off-by: Raghav Narula <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.github/workflows/pr-validate.yml, a PR-triggered workflow that fans out the full test suite across every supported platform on public GitHub-hosted runners with no secrets (source is checked out from git; all integration-test services come from public container images).Jobs (parallel)
unit(×4)ubuntu-latest), linux aarch64 (ubuntu-24.04-arm), macOS (macos-latest), Windows (windows-latest)cargo test --workspaceintegrationlore-integration-tests/compose.yaml, thencargo test -p lore-integration-tests --features integration_testssmoke(×4)lore+loreserver(--features lore-server/failure_generator), thenuv run pytest scripts/test -m smoke -n 4PR Validateneeds: [unit, integration, smoke]; passes only when all succeed — the single check to require in branch protectionNotes
127.0.0.1:9000/9090/8500, which the compose file maps.protocneeded —lore-proto/build.rsfalls back to the checked-in generated sources;cc/cbindgen are library deps, so Windows needs no extra tooling.failure_generatorso fault-injection smoke tests execute rather than skip cleanly.lint.yml; third-party actions (dtolnay/rust-toolchain,Swatinem/rust-cache,astral-sh/setup-uv) currently use release tags — a comment flags pinning them to SHAs if a stricter supply-chain policy is desired.🤖 Generated with Claude Code