Uncap datacarrier by default#1552
Draft
ivanlele wants to merge 2 commits into
Draft
Conversation
ivanlele
force-pushed
the
cherry/uncap-datacarrier-by-default
branch
2 times, most recently
from
97d48ec to
96c6166
Compare
Member
|
Looks good so far, just needs an update to one of the functional tests (or a new functional test) to check it's working correctly |
a189d63 add release note for datacarriersize default change (Greg Sanders) a141e1b Add more OP_RETURN mempool acceptance functional tests (Peter Todd) 0b4048c datacarrier: deprecate startup arguments for future removal (Greg Sanders) 63091b7 test: remove unnecessary -datacarriersize args from tests (Greg Sanders) 9f36962 policy: uncap datacarrier by default (Greg Sanders) Pull request description: Retains the `-datacarrier*` args, marks them as deprecated, and does not require another startup argument for multiple OP_RETURN outputs. If a user has set `-datacarriersize` the value is "budgeted" across all seen OP_RETURN output scriptPubKeys. In other words the total script bytes stays the same, but can be spread across any number of outputs. This is done to not introduce an additional argument to support multiple outputs. I do not advise people use the option with custom arguments and it is marked as deprecated to not mislead as a promise to offer it forever. The argument itself can be removed in some future release to clean up the code and minimize footguns for users. Tree-SHA512: 3da2f1ef2f50884d4da7e50df2121bf175cb826edaa14ba7c3068a6d5b2a70beb426edc55d50338ee1d9686b9f74fdf9e10d30fb26a023a718dd82fa1e77b038
Reverts commit 0b4048c
ivanlele
force-pushed
the
cherry/uncap-datacarrier-by-default
branch
from
96c6166 to
b521a1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picks:
bitcoin/bitcoin@f3bbc746647d1fd23bf5cfe
bitcoin/bitcoin@451ba9a