perf: resume the affine candidate scan from the fold's lowest rewritten factor#960
Open
rasros wants to merge 1 commit into
Open
perf: resume the affine candidate scan from the fold's lowest rewritten factor#960rasros wants to merge 1 commit into
rasros wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advances #937 (steelmillslab).
What changed
Why
findAffineCandidatewalks the live factors in stable-id order and is called once per elimination, so the loop was O(eliminations · factors). A fold only changes the content of the factors it rewrites (the pivot's occurrences), so no factor below their minimum id can newly become a candidate — everything below is a confirmed non-candidate, unchanged since it was last examined. Resuming the scan from that minimum keeps the exact lowest-id selection order (so the eliminations are unchanged) while turning the loop into O(factors + Σ rewrites). steelmillslab presolve drops from ~490ms to ~410ms (under 0.5s at budget=0); the alias rename rewrites the whole set, so it still rescans from 0.Testing