perf: seed symmetry colour refinement by survivors on wide-sparse domains#959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advances #938 (the liner-sf half).
What changed
domainSeed) from a variable's survivors rather than its holes when the domain is sparser than dense.Why
domainSeedfingerprinted each integer variable by enumerating its domain holes, building an O(span)LongArraykey. On liner-sf-repositioning — domains spanning up to 20M for a handful of live values — that key is tens of millions of words, and everyRefineKeyhash/compare across the refinement rounds then costs O(span).BREAK_SYMMETRIESalone took 741ms of liner-sf's 800ms presolve (and it finds no symmetry to break). Fingerprinting by whichever of holes or survivors is smaller drops liner-sf presolve to ~175ms — the liner-sf goal in #938, though the bottleneck was the symmetry colour seed rather than Element GAC as the issue hypothesized. 2DBinPacking is untouched, so #938 stays open.The two seed forms carry a distinct marker word, and within a form equal domains yield equal keys and distinct domains distinct keys, so the colour partition — and every generator found — is identical.
Testing