perf: fold wide-sparse domain reductions as compact survivor sets#958
Open
rasros wants to merge 1 commit into
Open
perf: fold wide-sparse domain reductions as compact survivor sets#958rasros wants to merge 1 commit into
rasros wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
restrictIntToSurvivorsandpropagateAtomsForSetRestriction, which wake the affected order/eq atoms off the value-sorted atom index in O(survivors + eq-atoms).bitsetThreshold; narrower reductions keep the plain hole path, whose holes are few and which carries the pre-existing-seed dedup.contains.EmptyIntArray/EmptyLongArrayfromFactortoutil.Why
liner-sf-repositioning finishes presolve over 1s because the bake folds Element-GAC-reduced domains through
SurvivorsDomain.forEachHole, which is O(span) over domains spanning millions for a handful of survivors (#938). Recording the survivors directly drops liner-sf presolve to ~0.76s and proteindesign/is/tdtsp by 5-11%.Testing