refactor: split LpBounding into shaving and primal-heuristics files#953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Carve two cohesive clusters out of
LpBounding.kt(the largest file in the codebase at ~1.2K lines) into their own files in the same package:LpShaving.kt— root LP shaving and structural deductions:shaveObjectiveLb,shaveVariableBounds,redundantConstraints,impliedEqualities,rootInfeasible,rootRelaxationSize, and their private helpers/constants.LpPrimalHeuristics.kt— the LP primal heuristics:lpRoundingProbe,lpFeasibilityPump, and their rounding/pump/perturbation helpers and constants.LpBounding.ktkeeps the per-node pruning, reduced-cost fixing, Farkas nogoods, and root-cut harvesting (its core), dropping from ~1229 to ~760 lines.Two helpers used across the clusters (
dualSimplex,pinToward) are widened from file-private tointernal.Why
LpBounding.kthad grown into a grab-bag of ~40LpEngineextension functions spanning several distinct concerns. Grouping them by concern makes each navigable and gives shaving and the primal heuristics a clear home.Testing
Pure relocation of top-level extension functions within the same package — no logic or signature changes beyond the two
internalwidenings, so callers are untouched and behavior is identical. Fullcheck lintDocsgreen across JVM + native + wasm; no benchmark needed (identical code paths).