test: unit-test the backtrack collaborators and relocate selector tests#949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
RestartControllerTest— the Luby budget sequence, per-run budget scaling, restart-index counting, and the adaptive/unbounded schedules.PhaseSavingTest— saved/target phase ordering per rephase mode, deepest-prefix capture, and theonConflictTickrotation.OccurrenceIndexTest— variable→factor inversion and the LS-aliases-CP-lists invariant.DeadlinePollerTest— the adaptive poll cadence, driven deterministically.DeadlinePollera constructor-injectedTimeSource.WithComparableMarks(defaultTimeSource.Monotonic) so its cadence is testable withTestTimeSource. No production call-site change.Vsids/DomWdeg/LastConflicttests out of the 792-lineBacktrackSolverTestgrab-bag intoselector/VsidsTest,selector/DomWdegTest,selector/LastConflictTest, matching the one-test-file-per-selector convention already used acrossselector/.Why
The engine split created independently-testable units with no direct tests — a bug in the Luby sequence or a rephase-mode ordering would only surface as a search-quality wobble, impossible to localize. And the selector tests sat in the wrong file (
BacktrackSolverTestrather than beside the selector under test).Testing
New tests only;
BacktrackSolverTestbehavior is unchanged (tests moved verbatim). Fullcheck lintDocsgreen across JVM + native + wasm.