feat: lint native-breaking backtick test names#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
checkNativeSafeTestNamesverification task to thecom.eignex.lintconvention plugin. It scans**/*Test/kotlin/**/*.ktand fails with afile:lineon anyfun \…`whose name contains(,), or#`.check.Why
Kotlin/Native (and Android dex) reject characters in backtick identifiers that the JVM accepts, so a test name like
foo (#389)compiles for jvm but fails the native compile with a cryptic error. This catches it early with an actionable message instead of deep in the build.Testing
./gradlew compileKotlinpasses. Consumers pick it up viacheckonce they bump the plugin version.