Make publish opt-out and fix the JVM mavenJava publication#12
Merged
Conversation
…mavenJava publication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Putting an internal module (the klause benchmark harness) on com.eignex.jvm surfaced two gaps. First, the convention always forces publish wiring, which requires a githubRepo and is meaningless for a module that is never released. Second, the JVM half of the publish convention had never been exercised — every consumer so far is KMP, where the multiplatform plugin auto-creates publications — so the named("mavenJava") call failed with "Publication with name 'mavenJava' not found" on the first real JVM consumer. Both are now fixed, and the jvm-positive sample exercises the convention end to end so it does not regress.
Testing
Ran the full samples smoke test green: jvm-positive passes check and publishes mavenJava to local staging, kmp-positive runs wasmWasiNodeTest on the pinned node, cli-positive builds and runs, and the negative samples still fire their expected rules. Separately verified the opt-out by setting publish to false with no githubRepo — check still configures and passes and no publish tasks are created. The plugin build and the LintPluginRulesTest suite pass.