You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now there is no way to specify secret generated outside of the chart to be passed as environment variables making custom non-microservices dotnet deployments hard to pass secrets.
It adds such possibility without breaking current flow - fully backward compatible.
▎ The change is simple, correct, and fully backward compatible. A few notes:
▎
▎ Redundant inner condition — the inner {{- if .Values.global.extraEnvFrom }} check is redundant because the outer or condition already guards the envFrom block. An empty list [] is falsy in Go templates, so both
▎ conditions behave identically. Consider removing the inner guard:
▎ {{- if .Values.global.extraEnvFrom }}
▎ {{- toYaml .Values.global.extraEnvFrom | nindent 12 }}
▎ {{- end }}
▎ can stay as-is if you prefer the explicit guard for readability, but it's not needed for correctness.
▎
▎ Missing Helm unit test — the PR checklist mentions template tests. There's no test covering the extraEnvFrom path (non-empty list should render envFrom entries correctly). Given the chart likely has a tests/ directory,
▎ this is straightforward to add.
▎
▎ Checklist — all items are unchecked including the description box, even though a description is present. Worth ticking the boxes before merge.
▎
▎ Overall: approve pending the test addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Right now there is no way to specify secret generated outside of the chart to be passed as environment variables making custom non-microservices dotnet deployments hard to pass secrets.
It adds such possibility without breaking current flow - fully backward compatible.
Chart
Select the chart that you are modifying:
Checklist
${CHART}/tests/*.py