Port conv_water_4rad to atmos_phys (convective_cloud_water) and cloud_water_paths - #428
Open
jimmielin wants to merge 6 commits into
Open
Port conv_water_4rad to atmos_phys (convective_cloud_water) and cloud_water_paths#428jimmielin wants to merge 6 commits into
jimmielin wants to merge 6 commits into
Conversation
added 4 commits
July 22, 2026 14:52
…_water_paths Assisted-by: claude-fable:5 Signed-off-by: Haipeng Lin <[email protected]> This is a combination of 3 commits. Add convective_cloud_water scheme (portable core of CAM conv_water_4rad) Science core split out of CAM's conv_water.F90 (conv_water_4rad), with r8 swept to kind_phys; the science body is bit-for-bit the code validated by CAM regression testing of the conv_water refactor. CAM builds this file through the atmos_phys external and keeps a thin conv_water wrapper owning pbuf marshaling, the conv_water_nl namelist, and history output. Add convective_cloud_water_diagnostics and the cloud_water test suite CAM-parity history output for convective_cloud_water (ICLMRCU, ICIMRCU, ICLMRTOT, ICIMRTOT, GCLMRSH, GCLMRDP, GCIMRSH, GCIMRDP, FRESH, FREDP, FRECU, FRETOT) so CAM-SIMA regression tests of the suite produce a baseline. The suite runs convective_cloud_water from a CAM snapshot captured around cloud_diagnostics_calc; cloud_water_paths joins the suite when it is ported.
added 2 commits
July 27, 2026 13:41
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (The PR title should also include the tag name):
Originator(s): @jimmielin (co-authored with
claude-fable:5)Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
conv_water_4rad(src/physics/cam/conv_water.F90) andcloud_diagnostics_calc(src/physics/cam/cloud_diagnostics.F90),The first one is a portable core scheme reused in CAM.
List all namelist files that were added or changed:
A schemes/cloud_water/convective_cloud_water_namelist.xml
List all files eliminated and why: N/A
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status main...<your_branch_name>)List all automated tests that failed, as well as an explanation for why they weren't fixed:
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
Yes
New physics package
If yes to the above question, describe how this code was validated with the new/modified features: