Export CO2 value to the land model via coupler - #427
Merged
Conversation
added 2 commits
July 22, 2026 16:21
…co2diag_tbd to land model. Provenance: FIX-31 octopus Assisted-by: claude-fable:5
Collaborator
Author
|
Thanks @nusbaume for the comments - I have updated the PR to just use |
nusbaume
approved these changes
Jul 30, 2026
nusbaume
left a comment
nusbaume
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @jimmielin! I have one change request but it doesn't require a re-review.
Co-authored-by: Jesse Nusbaumer <[email protected]>
peverwhee
approved these changes
Jul 30, 2026
…mospheric_physics into hplin/co2_diagnostic_export
jimmielin
added a commit
to ESCOMP/CAM-SIMA
that referenced
this pull request
Jul 31, 2026
Tag name (required for release branches): sima0_17_001 Originator(s): @jimmielin AI tools used (if applicable; please also add the "AI-generated code" label to the PR): What: claude-fable:5 How: wrote the companion PR Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number): - Companion PR to ESCOMP/atmospheric_physics#427 - Adds standard name of `co2diag` previously `co2diag_tbd` Describe any changes made to build system: Describe any changes made to the namelist: List any changes to the defaults for the input datasets (e.g. boundary datasets): List all files eliminated and why: List all files added and what they do: List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) M src/data/registry.xml add standard name for co2diag M src/data/generate_registry_data.py fix bitrot in parsing when calling gen registry data manually If there are new failures (compared to the `test/existing-test-failures.txt` file), have them OK'd by the gatekeeper, note them here, and add them to the file. If there are baseline differences, include the test and the reason for the diff. What is the nature of the change? Roundoff? derecho/intel/aux_sima: ``` SMS_D_Ln9.mpasa120_mpasa120.QPC4.derecho_intel.cam-outfrq_analy_ic_cam4 (Overall: NLFAIL) details: FAIL SMS_D_Ln9.mpasa120_mpasa120.QPC4.derecho_intel.cam-outfrq_analy_ic_cam4 NLCOMP SMS_D_Ln9.ne3pg3_ne3pg3_mt232.QPC4.derecho_intel.cam-outfrq_se_cam4 (Overall: NLFAIL) details: FAIL SMS_D_Ln9.ne3pg3_ne3pg3_mt232.QPC4.derecho_intel.cam-outfrq_se_cam4 NLCOMP SMS_Ln9.mpasa120_mpasa120.QPC4.derecho_intel.cam-outfrq_analy_ic_cam4 (Overall: NLFAIL) details: FAIL SMS_Ln9.mpasa120_mpasa120.QPC4.derecho_intel.cam-outfrq_analy_ic_cam4 NLCOMP SMS_Ln9.ne3pg3_ne3pg3_mt232.QPC4.derecho_intel.cam-outfrq_se_cam4 (Overall: NLFAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mt232.QPC4.derecho_intel.cam-outfrq_se_cam4 NLCOMP - new namelist surface_coupling_nl SMS_Ln9.ne3pg3_ne3pg3_mg37.FKESSLER.derecho_intel.cam-outfrq_se_cslam_multitape (Overall: NLFAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.FKESSLER.derecho_intel.cam-outfrq_se_cslam_multitape NLCOMP - pre-existing failure ``` derecho/gnu/aux_sima: ``` SMS_D_Ln9.mpasa120_mpasa120.QPC4.derecho_gnu.cam-outfrq_analy_ic_cam4 (Overall: NLFAIL) details: FAIL SMS_D_Ln9.mpasa120_mpasa120.QPC4.derecho_gnu.cam-outfrq_analy_ic_cam4 NLCOMP SMS_D_Ln9.ne3pg3_ne3pg3_mt232.QPC4.derecho_gnu.cam-outfrq_se_cam4 (Overall: NLFAIL) details: FAIL SMS_D_Ln9.ne3pg3_ne3pg3_mt232.QPC4.derecho_gnu.cam-outfrq_se_cam4 NLCOMP SMS_Ln9.mpasa120_mpasa120.QPC4.derecho_gnu.cam-outfrq_analy_ic_cam4 (Overall: NLFAIL) details: FAIL SMS_Ln9.mpasa120_mpasa120.QPC4.derecho_gnu.cam-outfrq_analy_ic_cam4 NLCOMP SMS_Ln9.ne3pg3_ne3pg3_mt232.QPC4.derecho_gnu.cam-outfrq_se_cam4 (Overall: NLFAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mt232.QPC4.derecho_gnu.cam-outfrq_se_cam4 NLCOMP Found extra namelist: surface_coupling_nl ``` derecho/nvhpc/aux_sima (test is run via Github workflow. Only run the test manually if we need to save new baselines): ``` SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_nvhpc.cam-outfrq_rrtmgp_derecho_gpu (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_nvhpc.cam-outfrq_rrtmgp_derecho_gpu NLCOMP - extra NL variable: scale_dry_air_mass (appears to be intro'd in sima0_17_000 but nvhpc baseline missing for that tag.) ``` If this changes climate describe any run(s) done to evaluate the new climate in enough detail that it(they) could be reproduced: CAM-SIMA date used for the baseline comparison tests if different than latest: --------- Co-authored-by: Haipeng Lin <[email protected]> Co-authored-by: Haipeng Lin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (The PR title should also include the tag name):
Originator(s): @jimmielin assisted-by claude-fable:5
Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
set_surface_coupling_varsscheme to pass theprescribed_volume_mixing_ratio_of_co2prescribed viaprescribe_radiative_gas_concentrationsto the couplerCAM just does this in
camsrfexch.F90List all namelist files that were added or changed:
A schemes/utilities/set_surface_coupling_vars_namelist.xml
List all files eliminated and why:
List all files added and what they do: N/A
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status main...<your_branch_name>)List all automated tests that failed, as well as an explanation for why they weren't fixed:
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
If yes to the above question, describe how this code was validated with the new/modified features: