Persist LW/SW fluxes across non-radiation timesteps - #426
Merged
Conversation
added 2 commits
July 22, 2026 16:16
Provenance: FIX-27 octopus Assisted-by: claude-fable:5
Must be paired with the CAM-SIMA registry fix so the data is retained across timesteps instead of being phase-local. Provenance: FIX-30 octopus Assisted-by: claude-fable:5
jimmielin
added
bug-fix
jimmielin
added a commit
to ESCOMP/CAM-SIMA
that referenced
this pull request
Jul 31, 2026
…ry. (#527) Tag name (required for release branches): sima0_17_002 Originator(s): @jimmielin AI tools used (if applicable; please also add the "AI-generated code" label to the PR): What: claude-fable:5 How: discovered that this fix is necessary. Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number): - Add sw/lw radiative net fluxes to the registry to be persisted across timesteps (even across non-radiation timesteps), to align behavior with CAM - Companion atmos_phys PR ESCOMP/atmospheric_physics#426 Describe any changes made to build system: Describe any changes made to the namelist: List any changes to the defaults for the input datasets (e.g. boundary datasets): List all files eliminated and why: List all files added and what they do: List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) M src/data/registry.xml adds fns, fcns, fnl, fcnl to registry If there are new failures (compared to the `test/existing-test-failures.txt` file), have them OK'd by the gatekeeper, note them here, and add them to the file. If there are baseline differences, include the test and the reason for the diff. What is the nature of the change? Roundoff? derecho/intel/aux_sima: ``` SMS_D_Ln9.mpasa120_mpasa120.QPC4.derecho_intel.cam-outfrq_analy_ic_cam4 (Overall: DIFF) details: FAIL SMS_D_Ln9.mpasa120_mpasa120.QPC4.derecho_intel.cam-outfrq_analy_ic_cam4 BASELINE /glade/campaign/cesm/community/amwg/sima_baselines/latest_intel: DIFF SMS_D_Ln9.ne3pg3_ne3pg3_mt232.QPC4.derecho_intel.cam-outfrq_se_cam4 (Overall: DIFF) details: FAIL SMS_D_Ln9.ne3pg3_ne3pg3_mt232.QPC4.derecho_intel.cam-outfrq_se_cam4 BASELINE /glade/campaign/cesm/community/amwg/sima_baselines/latest_intel: DIFF SMS_Ln9.mpasa120_mpasa120.QPC4.derecho_intel.cam-outfrq_analy_ic_cam4 (Overall: DIFF) details: FAIL SMS_Ln9.mpasa120_mpasa120.QPC4.derecho_intel.cam-outfrq_analy_ic_cam4 BASELINE /glade/campaign/cesm/community/amwg/sima_baselines/latest_intel: DIFF SMS_Ln9.ne3pg3_ne3pg3_mt232.QPC4.derecho_intel.cam-outfrq_se_cam4 (Overall: DIFF) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mt232.QPC4.derecho_intel.cam-outfrq_se_cam4 BASELINE /glade/campaign/cesm/community/amwg/sima_baselines/latest_intel: DIFF - atmImp_Faxa_lwdn, atmImp_Faxa_swndf, atmImp_Faxa_swndr, atmImp_Faxa_swnet, atmImp_Faxa_swvdf, atmImp_Faxa_swvdr now threaded through the coupler. No answer chg in model state. SMS_Ln9.ne3pg3_ne3pg3_mg37.FKESSLER.derecho_intel.cam-outfrq_se_cslam_multitape (Overall: NLFAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.FKESSLER.derecho_intel.cam-outfrq_se_cslam_multitape NLCOMP - pre-existing failure ``` derecho/gnu/aux_sima: ``` SMS_D_Ln9.mpasa120_mpasa120.QPC4.derecho_gnu.cam-outfrq_analy_ic_cam4 (Overall: DIFF) details: FAIL SMS_D_Ln9.mpasa120_mpasa120.QPC4.derecho_gnu.cam-outfrq_analy_ic_cam4 BASELINE /glade/campaign/cesm/community/amwg/sima_baselines/latest_gnu: DIFF SMS_D_Ln9.ne3pg3_ne3pg3_mt232.QPC4.derecho_gnu.cam-outfrq_se_cam4 (Overall: DIFF) details: FAIL SMS_D_Ln9.ne3pg3_ne3pg3_mt232.QPC4.derecho_gnu.cam-outfrq_se_cam4 BASELINE /glade/campaign/cesm/community/amwg/sima_baselines/latest_gnu: DIFF SMS_Ln9.mpasa120_mpasa120.QPC4.derecho_gnu.cam-outfrq_analy_ic_cam4 (Overall: DIFF) details: FAIL SMS_Ln9.mpasa120_mpasa120.QPC4.derecho_gnu.cam-outfrq_analy_ic_cam4 BASELINE /glade/campaign/cesm/community/amwg/sima_baselines/latest_gnu: DIFF SMS_Ln9.ne3pg3_ne3pg3_mt232.QPC4.derecho_gnu.cam-outfrq_se_cam4 (Overall: DIFF) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mt232.QPC4.derecho_gnu.cam-outfrq_se_cam4 BASELINE /glade/campaign/cesm/community/amwg/sima_baselines/latest_gnu: DIFF - atmImp_Faxa_lwdn, atmImp_Faxa_swndf, atmImp_Faxa_swndr, atmImp_Faxa_swnet, atmImp_Faxa_swvdf, atmImp_Faxa_swvdr now threaded through the coupler. No answer chg in model state. ``` derecho/nvhpc/aux_sima (test is run via Github workflow. Only run the test manually if we need to save new baselines): All PASS If this changes climate describe any run(s) done to evaluate the new climate in enough detail that it(they) could be reproduced: CAM-SIMA date used for the baseline comparison tests if different than latest: --------- Co-authored-by: Haipeng Lin <[email protected]> Co-authored-by: Haipeng Lin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (The PR title should also include the tag name):
Originator(s): @jimmielin
Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
_to_coupler) from post-interstitialList all namelist files that were added or changed:
List all files eliminated and why:
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status main...<your_branch_name>)List all automated tests that failed, as well as an explanation for why they weren't fixed:
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
If yes to the above question, describe how this code was validated with the new/modified features: