Mangager session flow - #807
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| [noDataMessage]="noDataMessage()" | ||
| [tableData]="tableData()" | ||
| [totalCount]="totalCount()" | ||
| (onClickEvent)="onCLickEvent($event)" |
There was a problem hiding this comment.
onCLickEvent -> onClickEvent
| @@ -27,7 +29,7 @@ | |||
| <ion-row class="d-flex flex-justify-center"> | |||
| <ion-col padding size-xs="12" size-sm="12" size-md="8" size-lg="6" align-self-stretch> | |||
There was a problem hiding this comment.
I think this padding is deprecated use ion-padding class
| noDataMessage: any; | ||
| segmentType = 'manage-session'; | ||
| noDataMessage = signal<any>(null); | ||
| segmentType = signal<string>('manage-session'); |
There was a problem hiding this comment.
segmentType = signal<'manage-session' | 'bulk-upload'>('manage-session');
| private adminWorkapceService: AdminWorkapceService, | ||
| private router: Router, | ||
| private modalCtrl: ModalController, | ||
| private cdr: ChangeDetectorRef |
There was a problem hiding this comment.
While using the signal, change detectr is not required
There was a problem hiding this comment.
Duplicate api call in OnInit and ViewWillEnter. use only
ViewWillEnter
There was a problem hiding this comment.
onCLickEvent -> onClickEvent
6a08449
into
ELEVATE-Project:release-3.4.0_ng20
2 participants
No description provided.