feat(create-session): add test cases and new angular update for sessi… by rohxnn · Pull Request #806 · ELEVATE-Project/mentoring-mobile-app

rohxnn · 2026-02-24T12:36:09Z

…on creation flow

coderabbitai · 2026-02-24T12:36:21Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

vishwanath1004 · 2026-02-25T04:07:30Z

-    [(ngModel)]="searchTerm"
-    (ionInput)="filterItems($event)"
-    placeholder="Search..."
+  <ion-searchbar [(ngModel)]="searchTerm" (ionInput)="filterItems($event)" placeholder="Search..."


use translate for the placeholder

vishwanath1004 · 2026-02-25T04:10:33Z

  <div class="height">
    <div class="height" [ngSwitch]="type">
      <ion-list class="height" *ngSwitchCase="'default'">
        <ion-content class="ion-padding">


Remove the inner ion-content

vishwanath1004 · 2026-02-25T04:13:34Z

+    <ion-button expand="full" (click)="onSubmit()">{{'SAVE' | translate}}</ion-button>
+    }
  </div>
+  @if (isNotCompleted) {


reduce the nested conditions. Do it like this : get showMeetingSubmit(): boolean {
return this.isNotCompleted && this.type === 'segment';
} and in html @if (showMeetingSubmit) {

vishwanath1004 · 2026-02-25T04:14:58Z

          </ion-card-header>
          <ion-card-content>
            <ion-list>
              <ion-select #link class="select" [(ngModel)]="selectedLink" interface="popover" (ionChange)="clickOptions($event)" [compareWith]="compareWithFn" [value]="selectedLink">


use ngModel and remove the value

vishwanath1004 · 2026-02-25T04:16:08Z

-            <div *ngFor="let option of meetingPlatforms">
-              <app-dynamic-form *ngIf="selectedLink==option" [jsonFormData]=option.form #platformForm></app-dynamic-form>
-          </div>
+            @for (option of meetingPlatforms; track option.name) {


Keep this logic in ts file

vishwanath1004 · 2026-02-25T04:31:59Z

  <div class="height">
    <div class="height" [ngSwitch]="type">
      <ion-list class="height" *ngSwitchCase="'default'">
        <ion-content class="ion-padding">


Ducplicate ion-content

vishwanath1004 · 2026-02-25T04:33:57Z

@@ -51,13 +61,21 @@

 <section [ngClass]="{'btn-disabled': form1?.myForm.invalid , 'btn-valid':form1?.myForm.valid}">


Wrap it in the footer

vishwanath1004 · 2026-02-25T04:36:02Z

            <ion-list>
              <ion-select #link class="select" [(ngModel)]="selectedLink" interface="popover" (ionChange)="clickOptions($event)" [compareWith]="compareWithFn" [value]="selectedLink">
-                <ion-select-option [value]="option" *ngFor="let option of meetingPlatforms">
+                @for (option of meetingPlatforms; track $index) {


Instead of index use option.name

vishwanath1004 · 2026-02-25T04:36:22Z

-  <div class="ion-no-border segment" submitButton *ngIf="type == 'segment'">
-    <ion-button *ngIf="sessionDetails?.meeting_info?.platform === 'OFF'" class="btns" size="default" fill="solid" (click)="setItLater()">{{'SET_IT_LATER' | translate}}</ion-button>
-    <ion-button [disabled]="platformForm && !platformForm.myForm.valid" class="btns" size="default" (click)="onSubmitLink()">{{'SUBMIT' | translate}}</ion-button>
+    @if (type == 'default' && !id) {


repeated checks

vishwanath1004 · 2026-02-25T04:40:01Z

+    <ion-button expand="full" (click)="onSubmit()">{{'SAVE' | translate}}</ion-button>
+    }
  </div>
+  @if (isNotCompleted) {


move this logic to ts, and do something like this

get showMeetingSubmit(): boolean {
return this.isNotCompleted && this.type === 'segment';
} and in html : @if (showMeetingSubmit) {

vishwanath1004

Keep Component size control , Strong typing,
Service extraction , Subscription cleanup

vishwanath1004 · 2026-02-25T04:46:21Z

  ngOnInit() {
-      
+
  }


can we slipt this component to file upload service, form service to prefill the data so we can re use these services in other pages.

vishwanath1004 · 2026-02-25T04:49:29Z

+    this.formData = await this.form.populateEntity(this.formData, this.entityList);
+    this.cdr.detectChanges();
    this.permissionService.getPlatformConfig();
    this.activatedRoute.queryParamMap.subscribe(async (params) => {


Clear the subscriptions on ngDestroy

vishwanath1004 · 2026-02-25T04:51:54Z

-      
+
  }
  async ionViewWillEnter() {


reduce the workload of ionViewWILLEnter add new method inside this called initialise or something and split the each funcationality as methods something like this : async initializePage(){
await this.loadConfig();
await this.loadForm();
awai t this.loadSession();
}

vishwanath1004 · 2026-02-25T05:01:16Z

+  styleUrls: ['./create-session.page.scss'],
+  standalone: false
 })
 export class CreateSessionPage implements OnInit {


Split different reusable services like :
Form manage
Files upload and other if needed

vishwanath1004 · 2026-02-25T05:01:56Z

-      
+
  }
  async ionViewWillEnter() {


Reduce the load for this method, create a seperate method for each funcationality to handle

vishwanath1004 · 2026-02-25T05:02:23Z

+    this.formData = await this.form.populateEntity(this.formData, this.entityList);
+    this.cdr.detectChanges();
    this.permissionService.getPlatformConfig();
    this.activatedRoute.queryParamMap.subscribe(async (params) => {


Clear this on destroy

vishwanath1004 · 2026-02-25T05:08:31Z

+
+    @if (control?.showField != false) {
+    <small class="error-msg d-flex error-msg flex-align-items-center">
+      @if (myForm.get(control.name)?.touched && myForm.get(control.name)?.invalid) {


Each get() is expensive so we can do like this : @let ctrl = myForm.get(control.name); hen :- ctrl?.invalid && ctrl?.touched

vishwanath1004 · 2026-02-25T05:10:11Z

+    @if (control?.showField != false) {
    <ion-item
-      *ngIf="control?.showField != false"
      class="ion-no-padding"


repeated classes : [ngClass]="['ion-no-padding', control.class]"

i tried to combine but it is not working

vishwanath1004 · 2026-02-25T05:11:53Z

-        </ng-template>
-      </ion-popover>
-    </div>
+      @if (control.label !== '' && !['rating'].includes(control.type) && !['chip'].includes(control.type) && !['search'].includes(control.type)) {


multiple includes, do like this : hiddenLabelTypes = ['rating','chip','search']; then in html !hiddenLabelTypes.includes(control.type)

vishwanath1004 · 2026-02-25T05:17:13Z

+@for (filter of filterData(); track $index) {
+<div class="ion-padding-start ion-padding-top">
+  <ion-label class="sub-header">{{filter?.title}}</ion-label>
+  @for (data of filter?.options; track $index) {


track bby name

vishwanath1004 · 2026-02-25T05:20:31Z

@@ -1,51 +1,51 @@
-import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core';
+import { Component, EventEmitter, input, OnInit, Output, signal } from '@angular/core';
 import * as _ from 'lodash';


if not using remove ths

vishwanath1004 · 2026-02-25T05:23:53Z

-        (click)="saveLink()"
-      >
+      <ion-button color="primary" fill="solid"
+        [disabled]="(type === 'link' && (!link || showLinkError())) || (type === 'file' && !uploadedFile())"


use computed signlas for showLinkError() and uploadedFile()

vishwanath1004 · 2026-02-25T05:24:50Z

    </div>
  </ion-content>

  <div class="modal-footer">


use ion-footer

vishwanath1004 · 2026-02-25T05:28:53Z

-          isNew: true,
-        };
+      const obj = {
+        name: this.name ? this.name : this.uploadedFile().name,


this.uploadedFile().name this may crash if this.uploadedFile() is null

vishwanath1004 · 2026-02-25T05:33:19Z

-        });
-        await actionSheet.present();
+      const actionSheet = await this.actionSheetController.create({
+        header: 'Select Resource',


use translate

vishwanath1004 · 2026-02-25T05:33:50Z

+      });
+    } else if (this.type === 'link') {
+      const obj = {
+        name: this.name ? this.name : this.link,


name: this.name || this.link

vishwanath1004 · 2026-02-25T05:40:09Z

  <div class="d-flex flex-justify-center">
-    <div class="profile-container "
-      *ngIf="!profileImageData?.image || profileImageData?.image==''; else Img; let image">
+    @if (!profileImageData?.image || profileImageData?.image=='') {


In multiple places we are using the same condition so move this logic to ts. get hasImage(): boolean {
return !!this.profileImageData?.image;
} and in html use like this : @if (!hasImage)

vishwanath1004 · 2026-02-25T05:42:07Z

-    <div *ngIf="profileImageData?.location">
+    }
+    @if (profileImageData?.location) {
+    <div>


Div is not required for this

vishwanath1004 · 2026-02-25T05:45:39Z

-  <ng-container *ngFor="let data of selectedData; let i = index">
-<ion-chip *ngIf="i < 5 && (data.name || data.label) && control.meta.addPopupType != 'file'" class="color-red" [disabled]="control?.disabled || data?.type === 'ENROLLED'">  
+  }
+  @for (data of selectedData; track $index) {


dont use track by index anywhere

vishwanath1004 · 2026-02-25T05:47:32Z

+  <ion-chip (click)="viewSelectedList()" class="color-red"
    [disabled]="control?.disabled">
    <ion-icon class="icon" name="add-outline" color="light"></ion-icon>
    <ion-label>{{selectedData.length-5}} more</ion-label>


recalculates each change detection. beter move this logic into ts

feat(create-session): add test cases and new angular update for sessi…

7fdf9e8

…on creation flow

vishwanath1004 reviewed Feb 25, 2026

View reviewed changes

rohxnn added 3 commits February 26, 2026 15:28

refactor(session-creation): requested changes

19af1ff

refactor(create0session): requsted changes

2b49def

refactor(create0session): requsted changes

7623409

vishwanath1004 merged commit 9e3f1d7 into ELEVATE-Project:release-3.4.0_ng20 Mar 3, 2026
1 of 2 checks passed

		@@ -51,13 +61,21 @@

		<section [ngClass]="{'btn-disabled': form1?.myForm.invalid , 'btn-valid':form1?.myForm.valid}">

Uh oh!

Conversation

rohxnn commented Feb 24, 2026

Uh oh!

coderabbitai Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vishwanath1004 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

coderabbitai Bot commented Feb 24, 2026 •

edited

Loading