Skip to content

fix crash with fastnoise#83

Open
offbeat-stuff wants to merge 1 commit into
DrexHD:26.1from
offbeat-stuff:26.1
Open

fix crash with fastnoise#83
offbeat-stuff wants to merge 1 commit into
DrexHD:26.1from
offbeat-stuff:26.1

Conversation

@offbeat-stuff

Copy link
Copy Markdown

Hi, developer of fastnoise

I use the constructor outside paletted container, causing a crash b/c of unbound scoped value.

@DrexHD

DrexHD commented May 3, 2026

Copy link
Copy Markdown
Owner

Hi, thanks for the PR!
But this approach effectively disables antixray in any newly generated chunks when fastnoise is present, which isn't ideal!

@offbeat-stuff

Copy link
Copy Markdown
Author

huh? isn't the function only for when it read from a disk

@offbeat-stuff

Copy link
Copy Markdown
Author

Here's how I use that specific constructor.
I extend the palettedContainer class to basically count the no. of blocks added to it.
I then create another paletted container from said container's data.
So I don't think this approach is wrong

@offbeat-stuff

Copy link
Copy Markdown
Author
image ok the new paletted container is also created from said container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants