feat: enforce attachment validation (type, size, filename, malware hook) - #933
Merged
llinsss merged 2 commits intoAug 31, 2026
Merged
Conversation
- Add attachmentValidation.ts with MIME allowlist (PDF only), 10 MB size limit, filename sanitization (path traversal, null bytes, HTML injection, length), PDF magic-byte check, and a swappable malware- scan hook for server-side use - Wire UploadModal.tsx to validateAttachment() on both file-input change and drag-and-drop; show rejection reason in role=alert region - Add /api/attachments/validate route that re-runs the full server-side validator (magic bytes + MIME + size + filename + malware stub) via busboy multipart parsing - Add 65 unit/component tests covering success, failure, boundary, and ordering cases across both client and server validators
|
@DavidAkere204 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #875