Changes to Combine summarized in Evernote#33
Open
Gianco99 wants to merge 15 commits into
Open
Conversation
…ball.sh; fix submitCombine to workspace approach - Untrack pkl, png, pdf output files (now covered by .gitignore) - Untrack MiniTree submission scripts not intended for this PR - Add make_combine_tarball.sh for one-time Combine environment setup - Update submitCombine.py: pre-convert datacards to RooStats workspaces locally so worker nodes run combine in pure C++ without NFS access
Gianco99
force-pushed
the
Gianfranco_Limit_Implementation
branch
from
May 14, 2026 18:38
3bc5b19 to
34de656
Compare
jreic
reviewed
May 15, 2026
| mfv_signal_highM_samples_20162 + mfv_stopdbardbar_highM_samples_20162 + mfv_stopbbarbbar_highM_samples_20162 + | ||
| mfv_signal_highM_samples_2017 + mfv_stopdbardbar_highM_samples_2017 + mfv_stopbbarbbar_highM_samples_2017 + | ||
| mfv_signal_highM_samples_2018 + mfv_stopdbardbar_highM_samples_2018 + mfv_stopbbarbbar_highM_samples_2018): | ||
| if _SFmod.get(x.name, "ntuple_tag001bvetolhtm_highM") is not None: |
Contributor
There was a problem hiding this comment.
Is this _SFmod actually needed?
Contributor
Author
There was a problem hiding this comment.
M3000 at ctau ≥ 1mm hit the wall-time limit and were never produced, so those samples exist in the Samples list but have no entry in SampleFiles.. the _SFMod prevents registering these datasets that have no backing files.
Contributor
There was a problem hiding this comment.
Oh got it. For the high mass ones (if we don't simply drop them) we should consider aggressively splitting them, maybe to dozens of events per job rather than hundreds...
All Python/shell scripts for the sumdbv binning optimization study: scheme comparison (asymptotic + HybridNew), boundary scans, discovery significance cross-checks, and condor submission infrastructure. Also updates makeDatacard.py, submitCombine.py, plotLimits.py, limits_config.yaml for the new binning framework. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…son plots, NaN interp fix)
… renorm and VH factorization
… of disp_trig nuisances --- all to match AN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see here for summary of changes - https://share.evernote.com/note/6f19ad6d-d738-5995-7949-abb8323c00dd