Skip to content

Done Fixed Succesfully #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vamsi-o merged 1 commit into from
Nov 27, 2025
Merged

Done Fixed Succesfully #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/nodes/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
"clean": "rm -rf dist"
},
"keywords": [],
"exports" : {
"./nodeClinet" : "./dist/index.js"
},
Comment on lines +15 to +17

@coderabbitai coderabbitai Bot Nov 27, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Fix typo in exports key.

The export key contains a typo: "nodeClinet" should be "nodeClient". This will prevent consumers from correctly importing the module using the intended path.

Apply this diff to fix the typo:

   "exports" : {
-    "./nodeClinet" : "./dist/index.js"
+    "./nodeClient" : "./dist/index.js"
   },
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"exports" : {
"./nodeClinet" : "./dist/index.js"
},
"exports" : {
"./nodeClient" : "./dist/index.js"
},
🤖 Prompt for AI Agents 
In packages/nodes/package.json around lines 15 to 17, the "exports" key contains
a typo ("nodeClinet") which prevents correct imports; rename the key to
"nodeClient" (keeping the mapped value "./dist/index.js") so consumers can
import via "./nodeClient".

"author": "",
"license": "ISC",
"packageManager": "[email protected]",
Expand Down
8 changes: 4 additions & 4 deletions packages/nodes/src/google-sheets/google-sheets.executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { GoogleOAuthService } from "../common/google-oauth-service";
import { GoogleSheetsService, GoogleSheetsCredentials } from "./google-sheets.service";
import { GoogleOAuthService } from "../common/google-oauth-service.js";
import { GoogleSheetsService, GoogleSheetsCredentials } from "./google-sheets.service.js";

interface NodeExecutionContext{
nodeId: string,
Expand Down Expand Up @@ -106,5 +106,5 @@ class GoogleSheetsNodeExecutor{
}
}

export { GoogleSheetsNodeExecutor };
export type { NodeExecutionContext, NodeExecutionResult };
export default GoogleSheetsNodeExecutor ;
// export { NodeExecutionContext, NodeExecutionResult };
6 changes: 3 additions & 3 deletions packages/nodes/src/google-sheets/google-sheets.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import NodeRegistry from "../registry/node-registry";
import { GoogleSheetsNodeExecutor } from "./google-sheets.executor";
import NodeRegistry from "../registry/node-registry.js";
import GoogleSheetsNodeExecutor from "./google-sheets.executor.js";

export class GoogleSheetNode{
export class GoogleSheetNode {
static definition = {
id: "",
name: "Google Sheet",
Expand Down
12 changes: 6 additions & 6 deletions packages/nodes/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// Export everything from one place
// export * from './registry/node-registry';
// export * from './google-sheets/google-sheets.node';
// export * from './common/google-oauth-service';
// Central export for all major modules
// export { default as NodeRegistry } from './registry/node-registry.js';
export { GoogleSheetNode } from './google-sheets/google-sheets.node.js';
import GoogleSheetsNodeExecutor from './google-sheets/google-sheets.executor.js';

export {GoogleSheetsNodeExecutor}

console.log("Hello World From node / index.hs")

console.log("Hello World From node / index.ts");

@coderabbitai coderabbitai Bot Nov 27, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Remove debug console.log statement.

This console.log appears to be debug code and should not be present in production. It will create unnecessary logging noise.

Apply this diff to remove the debug statement:

 export {GoogleSheetsNodeExecutor}
-
-console.log("Hello World From node / index.ts");
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
console.log("Hello World From node / index.ts");
export {GoogleSheetsNodeExecutor}
🤖 Prompt for AI Agents 
In packages/nodes/src/index.ts at line 8 the debug console.log("Hello World From
node / index.ts") should be removed; delete that statement so the file no longer
emits this development log to avoid noisy production output.

2 changes: 1 addition & 1 deletion packages/nodes/src/registry/node-registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { prismaClient } from "@repo/db";
import { GoogleSheetNode } from "../google-sheets/google-sheets.node";
import { GoogleSheetNode } from "../google-sheets/google-sheets.node.js";

interface NodeDefinition{
id: string,
Expand Down