Skip to content

fixup: give required presigned headers directly to the client#334

Draft
cole-h wants to merge 1 commit into
mainfrom
server-side-headers
Draft

fixup: give required presigned headers directly to the client#334
cole-h wants to merge 1 commit into
mainfrom
server-side-headers

Conversation

@cole-h

@cole-h cole-h commented Jul 10, 2026

Copy link
Copy Markdown
Member

We still override ones with what we calculated (so if something went wrong, the upload will fail because of that), but there could be some additional headers that are unknowable to the client that we just have to send along verbatim.

We still override ones with what we calculated (so if something went
wrong, the upload will fail because of that), but there could be some
additional headers that are unknowable to the client that we just have
to send along verbatim.
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1e8de60c-242b-41e3-a859-083eb6d8418a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch server-side-headers

Comment @coderabbitai help to get the list of available commands.

@cole-h cole-h requested a review from colemickens July 10, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants