Task 2 4 1#15
Open
Denmurzik wants to merge 10 commits into
Open
Conversation
|
|
|
|
|
farkhutdinovDmitry
requested changes
Apr 25, 2026
| html.append("table{border-collapse:collapse;margin:10px 0;} "); | ||
| html.append("th,td{border:1px solid #000;padding:4px 8px;} "); | ||
| html.append("caption{text-align:left;font-weight:bold;padding:4px 0;} "); | ||
| html.append("</style></head><body>\n"); |
Collaborator
There was a problem hiding this comment.
объединить в один textblock?
| continue; | ||
| } | ||
|
|
||
| html.append("<h2>Группа ").append(escape(group.getName())).append("</h2>\n"); |
Collaborator
There was a problem hiding this comment.
более читаемый вариант сделать строку с плейсхолдером либо %s и через format подставить group.getName()
|
|
||
| private String labTable(Lab lab, List<StudentReport> reports) { | ||
| StringBuilder sb = new StringBuilder(); | ||
| sb.append("<table><caption>Лабораторная ").append(escape(lab.getId())) |
Collaborator
There was a problem hiding this comment.
аналогично коментам выше
| public int countViolations(File projectDir) { | ||
| File srcRoot = findJavaSrc(projectDir); | ||
| if (srcRoot == null) { | ||
| return -1; |
Collaborator
There was a problem hiding this comment.
может исключения для ошибок использовать все-таки?)
| File tmp = File.createTempFile("google_checks", ".xml"); | ||
| tmp.deleteOnExit(); | ||
| FileOutputStream out = new FileOutputStream(tmp); | ||
| byte[] buf = new byte[4096]; |
| return out.substring(idx + 1); | ||
| } | ||
| } | ||
| for (String b : new String[]{"main", "master"}) { |
Collaborator
There was a problem hiding this comment.
new String[]{"main", "master"}
это очень круто, но давайте в какой-нибудь константный лист в классе вынесем
| } | ||
|
|
||
| /** Запускает команду и возвращает результат. */ | ||
| public static Result run(File workDir, long timeoutSeconds, String... command) |
Collaborator
There was a problem hiding this comment.
может добавим немного ооп?
| public class App { | ||
|
|
||
| /** Парсит команду, находит DSL-скрипт и запускает проверку. */ | ||
| public static void main(String[] args) throws Exception { |
Collaborator
There was a problem hiding this comment.
давайте не кидаться исключениями, а ловить их и выводить пользователю инфу об ошибке
| File script = new File(workDir, "oop-checker.groovy"); | ||
| if (!script.exists()) { | ||
| System.err.println("В рабочей директории не найден oop-checker.groovy"); | ||
| System.exit(1); |
|
|
||
| Config config = new DslLoader().load(script); | ||
|
|
||
| if (command.equals("test") || command.equals("report")) { |
Collaborator
There was a problem hiding this comment.
в будущем собираемся добавить еще 10 команд. как поступим с текущим подходом?
|
| } | ||
| } catch (Exception ignore) { | ||
| // не смогли получить git log — возвращаем пустой список | ||
| } catch (GitOperationException e) { |
| } | ||
|
|
||
| /** Даты коммитов в диапазоне, в формате ISO. */ | ||
| public List<String> commitDates(File repoDir, LocalDate from, LocalDate to) { |
Collaborator
There was a problem hiding this comment.
может тогда не лист строк возвращать, а лист дат?
|
|
|
farkhutdinovDmitry
approved these changes
May 10, 2026
farkhutdinovDmitry
left a comment
farkhutdinovDmitry
left a comment
Collaborator
There was a problem hiding this comment.
нейминг коммитов по-прежнему бессодержательный, по остальному ок
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.