Task 2 3 1#14
Merged
Merged
Conversation
|
|
|
|
|
|
Denmurzik
requested review from
farkhutdinovDmitry
and removed request for
farkhutdinovDmitry
farkhutdinovDmitry
requested changes
Apr 4, 2026
| /** | ||
| * Контроллер. | ||
| */ | ||
| public class GameController { |
Collaborator
There was a problem hiding this comment.
у вас есть отдельный класс под View, при этом в GameController есть и управление бизнес-логикой, и элементами View. давайте разделим ответственности. классы View будут отвечать только за отрисовку интерфейса, они будут передавать контроллеру информацию о том, какое событие на интерфейсе произошло. контроллер в зависимости от этого вызывает соответствующий метод модели, модель уведомляет view о том, что произошли изменения
Denmurzik
requested review from
farkhutdinovDmitry
and removed request for
farkhutdinovDmitry
|
farkhutdinovDmitry
left a comment
farkhutdinovDmitry
left a comment
Collaborator
There was a problem hiding this comment.
сгруппируйте классы по пакетам
| /** | ||
| * Снимок состояния игры для отрисовки. | ||
| */ | ||
| public class GameSnapshot { |
|
|
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.