Add up/down key time navigation to temporal time spinner#49
Merged
Conversation
Make the 3D temporal stack's time reel focusable and step one slice at a time with ArrowUp/ArrowDown when it has focus (up = later, down = earlier), matching the drag and scroll metaphors. Adds slider ARIA roles and a focus-visible style. https://claude.ai/code/session_01Ko2yruDbXdBsZ8ZzgL4Y8L
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In the 3D temporal stack, the time reel ("time spinner") can now be navigated with the ↑/↓ arrow keys when it has focus.
Why
The reel previously only responded to drag/flick and mouse-wheel input, and wasn't keyboard-reachable at all. Keyboard navigation is more precise (one slice per keypress) and makes the control accessible.
How
.temporal-wheel-reelfocusable (tabIndex={0}) and gave itrole="slider"plusaria-valuemin/max/now/valuetextfor screen readers.onKeyDownhandler that steps one time slice per press, reusing the same slice-snapping logic as the wheel handler. ArrowUp = later time, ArrowDown = earlier, matching the existing drag-up/scroll metaphor. Inertia is cancelled on keypress andpreventDefaultkeeps the page from scrolling.:focus-visibleoutline so the focused reel is visible, and updated the hint text to mention the keys.Testing
npm run typecheck,npm run lint, andnpm run test:run(139 tests) all pass.https://claude.ai/code/session_01Ko2yruDbXdBsZ8ZzgL4Y8L
Generated by Claude Code