Remove the cost-mode toggle from the temporal view#48
Closed
IanMayo wants to merge 1 commit into
Closed
Conversation
|
The temporal stack's Total mode — the full composite cost for that time (permanent + temporal), heat-shaded — didn't read well in practice, so drop it. With Total gone there is nothing to toggle between, so remove the cost-mode control entirely: each temporal layer now always shows the temporal-only Δ from the permanent base (day/night, time-varying zones, worst-case weather) over a transparent background, which was already the view's default. This strips the now-dead Total path: the cost-mode state and type, the Total branch in buildSlice, the unused BaseInfo.baseNorm, and the Scene `temporal` prop (slices are always transparent, so they never write depth).
IanMayo
force-pushed
the
claude/relaxed-carson-8tnT3
branch
from
e56ba79 to
6ed83db
Compare
IanMayo
changed the title
Contributor
Author
|
drop - leave existing behaviour |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the temporal view's cost-mode toggle, so each temporal layer always shows the temporal-only Δ from the permanent base (day/night, time-varying zones, and the worst-case weather impact) over a transparent background — the view's original default.
Why
This PR originally surfaced a
Cost shown: Total / Temporal Onlytoggle. On review the Total mode — the full composite cost for that time (permanent + temporal), heat-shaded — didn't read well in practice. With Total dropped there is nothing to toggle between, so the control is removed entirely rather than left as a one-option stub.Changes
CostModetype.Totalbranch inbuildSlice; it now always builds the temporal-only Δ geometry.BaseInfo.baseNorm(only the Total heat path read it; the permanent base still uses its own local normaliser).temporalprop — slices are always transparent, so they never write depth (depthWrite={false}).Net effect vs
main: +20 / −54 insrc/ui/temporal/TemporalView.tsx. No engine, store, or domain changes.Checks
npm run typecheck,npm run lint,npm run test:run(139 passed), andnpm run buildall pass locally.https://claude.ai/code/session_01CvVH7S4BmmLtfxLmr86Ahw