Add Bill Cosby quote video generation flow - #19
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughA new ChangesRemotion Quote Video App
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c945335a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| paddingLeft: 64, | ||
| width: "100%", |
There was a problem hiding this comment.
Keep padded quote blocks inside the video frame
In the 1920x1080 composition, PageShell caps the content column at 768px and the surrounding <main> hides overflow; this blockquote then sets width: "100%" while adding a 64px left padding and 8px border, so its border box becomes wider than the container. The quote text is laid out against the full 768px content width but the right side is clipped by the parent, which can cut off long quote lines in the rendered video. Use border-box sizing or reduce the content width so the padded block fits inside the column.
Useful? React with 👍 / 👎.
| "genre": "family" | ||
| }, | ||
| { | ||
| "text": "In order to succeed, your desire for success should be greater than your fear of failure.", |
There was a problem hiding this comment.
Deduplicate the fixed random quote
SceneOneQuoteExpansion shows quote indexes 1 through 10 in the expanded list and then uses index 11 as the post-click random quote, but this committed entry repeats the exact text already shown at index 6. With the current data, the final random action therefore reveals a quote the viewer has already seen instead of a new random result; deduplicate by text before writing/selecting these fixed slots or replace this item.
Useful? React with 👍 / 👎.
| if (!quotes || quotes.length < 4) { | ||
| throw new Error("API returned too few Bill Cosby quotes"); |
There was a problem hiding this comment.
Require enough fetched quotes for every scripted slot
SceneOneQuoteExpansion consumes twelve quote slots (the first quote, ten list entries, and index 11 for the random reveal), but the prerender fetch accepts and writes any response with only four usable quotes. If the API returns 4–11 filtered quotes, npm run render overwrites the committed JSON with that short list and the remaining scripted slots fall back through getQuote, producing repeated fallback quotes instead of the fetched author flow; treat fewer than 12 as a fetch failure or adapt the scene to the returned count.
Useful? React with 👍 / 👎.
Summary
Testing
Summary by CodeRabbit
New Features
Chores